Bug 1245351 - Review Request: ps2emu-tools - PS/2 recording/playback tools for userio
Summary: Review Request: ps2emu-tools - PS/2 recording/playback tools for userio
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR
TreeView+ depends on / blocked
 
Reported: 2015-07-21 20:20 UTC by Lyude
Modified: 2021-08-20 02:56 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-08-03 18:31:40 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Lyude 2015-07-21 20:20:13 UTC
Spec URL: https://lyude.net/~lyudess/tmp/ps2emu/ps2emu-tools.spec
SRPM URL: https://lyude.net/~lyudess/tmp/ps2emu/ps2emu-tools-0.1.2-0.fc22.src.rpm

Description:
This contains a set of userspace tools for the ps2emu kernel modules that can record data coming from PS/2 devices, and play them back using the kernel module. The kernel module has not gone upstream yet, however the patches for it have been posted on the LKML[1] pending review, and ps2emu has already been used to fix one of the bugs on the Red Hat bugzilla[2]. You can also find a built version of this package on the copr[3].

[1] https://lkml.org/lkml/2015/7/21/685
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1235175
[3] https://copr.fedoraproject.org/coprs/lyude/ps2emu-tools/

Fedora Account System Username: lyude

Comment 1 Lyude 2015-07-30 01:12:53 UTC
(In reply to Lyude from comment #0)
> Spec URL: https://lyude.net/~lyudess/tmp/ps2emu/ps2emu-tools.spec
> SRPM URL:
> https://lyude.net/~lyudess/tmp/ps2emu/ps2emu-tools-0.1.2-0.fc22.src.rpm

As a side note, version 1.0 was just released, so the current SRPM can be found here: https://lyude.net/~lyudess/tmp/ps2emu/ps2emu-tools-1.0-0.fc22.src.rpm

Comment 2 Eduardo Mayorga 2015-07-31 01:36:38 UTC
Please update the Spec URL too.

Comment 3 Lyude 2015-08-11 22:25:31 UTC
Sorry about that! One of my HDDs on my server died a couple days ago and I guess the spec files weren't in the backup I restored. I've fixed the URLs, you can find everything in https://lyude.net/~lyudess/tmp/ps2emu now, in addition the spec file has been updated to the latest version of ps2emu

Comment 4 Lyude 2015-08-19 13:36:54 UTC
Adding a direct link to the srpm so fedora-review works with this bug https://lyude.net/~lyudess/tmp/ps2emu/ps2emu-tools-1.0.1-0.fc22.src.rpm

Comment 5 Ralf Corsepius 2015-08-31 17:05:24 UTC
Some remarks:

- Please add appropriate %changelog entries to the spec.

- %license is missing
Please add:
%license LICENSE

- This
%{_mandir}/man1/ps2emu-record.1.gz
%{_mandir}/man1/ps2emu-replay.1.gz
should be
%{_mandir}/man1/ps2emu-record.1*
%{_mandir}/man1/ps2emu-replay.1*

- Building is non-verbose:
...
  CC       ps2emu-record.o
  CC       ps2emu-event.o
...

This renders it impossible to check whether compilation receives the correct CFLAGS. Please append --disable-silent-rules to %configure

- Please increment %release each time you change something on your package. This helps avoiding troubles and misunderstanding during reviews.

Comment 6 Lyude 2015-09-02 14:56:00 UTC
Alright. I've made the changes you specified and updated the spec file to the latest build of ps2emu-tools. SRPM can now be found here:

https://lyude.net/~lyudess/tmp/ps2emu/ps2emu-tools-1.0.2-1.fc22.src.rpm

Comment 7 Lyude 2015-10-09 18:21:43 UTC
Adding FE-NEEDSPONSOR as a blocker to this so I can get a sponsor for this, and add the + flag for your package Chris. Sorry this took so long, things got a bit busy for a while.

Comment 8 Piotr Popieluch 2015-10-13 17:53:43 UTC
Seems that lyude.net is down.

Comment 9 Lyude 2015-10-13 17:57:35 UTC
(In reply to Piotr Popieluch from comment #8)
> Seems that lyude.net is down.

I swear this server only goes down when someone's about to review this bugzilla. Can't fix it right now, so I've just put the spec file on fpaste: http://paste.fedoraproject.org/278805/44759044

Comment 10 Piotr Popieluch 2015-10-13 18:10:26 UTC
You can use fedorapeople for uploading packages:

https://fedoraproject.org/wiki/Infrastructure/fedorapeople.org

Comment 11 Benjamin Tissoires 2016-02-22 16:02:16 UTC
Bumping this.

Christopher, Lyude was working with me on this project, and I'd like to see this package in Fedora. Is it OK if I take the review from you and continue doing it ? I will then mentor Lyude for the rest of the Fedora processes.

Comment 12 Package Review 2020-07-10 00:52:09 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 13 Package Review 2020-11-13 00:46:31 UTC
This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.


Note You need to log in before you can comment on or make changes to this bug.