RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1245525 - libvirt should reject metadata elements not belonging to any namespace
Summary: libvirt should reject metadata elements not belonging to any namespace
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.2
Hardware: x86_64
OS: Unspecified
unspecified
medium
Target Milestone: rc
: ---
Assignee: Peter Krempa
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-07-22 08:47 UTC by zhenfeng wang
Modified: 2016-11-03 18:20 UTC (History)
5 users (show)

Fixed In Version: libvirt-1.3.1-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-03 18:20:14 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2016:2577 0 normal SHIPPED_LIVE Moderate: libvirt security, bug fix, and enhancement update 2016-11-03 12:07:06 UTC

Description zhenfeng wang 2015-07-22 08:47:45 UTC 
Description of problem:
libvirt should reject to configure reduntant metadata element in the guest's xml
while these elements aren't in namespace

Version-Release number of selected component (if applicable):
libvirt-1.2.17-2.el7.x86_64

How reproducible:
100%

Steps
1.Prepare a shutoff guest
# virsh list --all
 Id    Name                           State
----------------------------------------------------
 -     7.0                          shut off

2.Edit guest's xml, add multi same metadata in guest's xml, It will generate many redundant records
in guest's xml
# virsh dumpxml 7.0
--
  <metadata>
    <herp2erp xmlns:foobar="http://foo.bar3/" xmlns:herp2="http://herp.derp/"/>
    <herp2erp xmlns:foobar="http://foo.bar3/" xmlns:herp2="http://herp.derp/"/>
    <herp2erp xmlns:foobar="http://foo.bar3/" xmlns:herp2="http://herp.derp/"/>
    <herp2erp xmlns:foobar="http://foo.bar3/" xmlns:herp2="http://herp.derp/"/>
    <herp2erp xmlns:foobar="http://foo.bar3/" xmlns:herp2="http://herp.derp/"/>
    <herp2erp xmlns:foobar="http://foo.bar3/" xmlns:herp2="http://herp.derp/"/>
    <herp2erp xmlns:foobar="http://foo.bar3/" xmlns:herp2="http://herp.derp/"/>
  </metadata>



Actual results:
Generate the redundant record in guest's xml while configure many same metadatas in guest's xml

Expected results:
libvirt should reject to configure reduntant metadata element in the guest's xml libvirt should reject to configure reduntant metadata element in the guest's xml
Comment 1 Peter Krempa 2015-07-22 08:53:23 UTC 
The problem is that the metadata elements don't belong to any namespace, but they should.
Comment 2 Peter Krempa 2015-10-06 11:39:40 UTC 
Fixed upstream:

commit 51a4178f24a7a7a88a36915b8b358a8321e3ef58
Author: Peter Krempa <pkrempa>
Date:   Mon Oct 5 09:58:30 2015 +0200

    conf: Remove <metadata> elements with no namespace
    
    Our docs state that subelements of <metadata> shall have a namespace
    and the medatata APIs expect that too. To avoid inaccessible
    <metadata> sub-elements, just remove those that don't conform to the
    documentation.
    
    Apart from adding the new condition this patch renames the function and
    refactors the code flow to allow the changes.
Comment 4 zhenfeng wang 2016-03-25 09:31:25 UTC 
Verify this bug with libvirt-1.3.2-1.el7.x86_64
1.Prepare a shutoff guest
# virsh list --all
 Id    Name                           State
----------------------------------------------------
 -     virt-tests-vm3                          shut off

2.Edit guest's xml, add multi same invalid metadata in guest's xml, libvirt will remove the invalid sub-elements from <metadata> element
in guest's xml
# virsh edit virt-tests-vm3
--
  <metadata>
    <herp2erp xmlns:foobar="http://foo.bar3/" xmlns:herp2="http://herp.derp/"/>
    <herp2erp xmlns:foobar="http://foo.bar3/" xmlns:herp2="http://herp.derp/"/>
    <herp2erp xmlns:foobar="http://foo.bar3/" xmlns:herp2="http://herp.derp/"/>
    <herp2erp xmlns:foobar="http://foo.bar3/" xmlns:herp2="http://herp.derp/"/>
    <herp2erp xmlns:foobar="http://foo.bar3/" xmlns:herp2="http://herp.derp/"/>
    <herp2erp xmlns:foobar="http://foo.bar3/" xmlns:herp2="http://herp.derp/"/>
    <herp2erp xmlns:foobar="http://foo.bar3/" xmlns:herp2="http://herp.derp/"/>
  </metadata>

#virsh dumpxml virt-tests-vm3
--
  <metadata/>

3.Edit guest's xml, add multi same valid metadata in guest's xml, save the guest's xml, only 1 record will generated
#virsh edit virt-tests-vm3
--
  <metadata>
<foobar:herp2erp xmlns:foobar="http://foo.bar3/"/>
<foobar:herp2erp xmlns:foobar="http://foo.bar3/"/>
<foobar:herp2erp xmlns:foobar="http://foo.bar3/"/>
<foobar:herp2erp xmlns:foobar="http://foo.bar3/"/>
<foobar:herp2erp xmlns:foobar="http://foo.bar3/"/>
<foobar:herp2erp xmlns:foobar="http://foo.bar3/"/>
<foobar:herp2erp xmlns:foobar="http://foo.bar3/"/>
  </metadata>

#virsh dumpxml virt-tests-vm3
  <metadata>
    <foobar:herp2erp xmlns:foobar="http://foo.bar3/"/>
  </metadata>

4.Do some basic check the metadata command, all command could get expect result.
# virsh metadata virt-tests-vm3 --uri http://foo.bar3/
<herp2erp/>

# virsh metadata virt-tests-vm3 --uri http://foo.bar3/ --edit --key foobar
<herp2erp1/>

# virsh metadata virt-tests-vm3 --uri http://foo.bar3/ 
<herp2erp1/>

# virsh metadata virt-tests-vm3 --uri http://foo.bar3/  --remove
Metadata removed

# virsh metadata virt-tests-vm3 --uri http://foo.bar3/ 
error: metadata not found: Requested metadata element is not present

According to upper steps, mark this bug verified
Comment 7 errata-xmlrpc 2016-11-03 18:20:14 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2577.html
Note You need to log in before you can comment on or make changes to this bug.