Spec URL: <spec info here> SRPM URL: http://people.redhat.com/~pbelange/fedora-review/libgsasl-1.8.0-6.fc24.src.rpm Description: Since Fedora 18, GSSAPI support has been missing from libgsasl. From the looks of it the configure script changed in version 1.8.0, not detecting the system libraries. Now, we explicitly pass the flags to enable GSSAPI support. Fedora Account System Username: pabelanger
Sorry, clicked submit too soon Spec URL: http://people.redhat.com/~pbelange/fedora-review/1246177/libgsasl.spec SRPM URL: http://people.redhat.com/~pbelange/fedora-review/1246177/libgsasl-1.8.0-6.fc24.src.rpm Description: Since Fedora 18, GSSAPI support has been missing from libgsasl. From the looks of it the configure script changed in version 1.8.0, not detecting the system libraries. Now, we explicitly pass the flags to enable GSSAPI support. Fedora Account System Username: pabelanger
Not sure what happen on the double post. Really noobed things up here.
koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10450050
$ rpmlint libgsasl-1.8.0-6.fc24.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint libgsasl.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
> %package devel > Requires: pkgconfig There's an automatic dependency on /usr/bin/pkgconfig and there are automatic pkgconfig(…) Provides for .pc file inter-dependencies, too. That applies to all current Fedora releases as well as RHEL 6. > %files -f %{name}.lang > %doc AUTHORS COPYING NEWS README THANKS > %files devel > %doc COPYING There is the special %license macro since early 2015: https://fedoraproject.org/wiki/Packaging:Guidelines#Licensing -> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text Plus, you don't need to duplicate the COPYING file in the -devel subpackage, because that one depends on the base package already: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing
Michael, Thanks for the review. I wanted to actually show the diff of my patchset that I didn't link in the original post (see below). I don't mind submitting a follow up patchs to address the existing packaging issues that you raise, however my current patchs really just toggles the build flags. --- diff --git a/libgsasl.spec b/libgsasl.spec index d77ed02..fb322a6 100644 --- a/libgsasl.spec +++ b/libgsasl.spec @@ -31,7 +31,7 @@ developing applications that use %{name}. %setup -q %build -%configure --disable-static --disable-rpath +%configure --disable-static --disable-rpath --with-gssapi-impl=mit make %{?_smp_mflags} %install @@ -54,6 +54,9 @@ find %{buildroot} -name '*.la' -exec rm -f {} ';' %{_libdir}/pkgconfig/libgsasl.pc %changelog +* Wed Jul 22 2015 Paul Belanger <pabelanger> - 1.8.0-7 +- Re-enable GSSAPI support (#1134957) + * Wed Jun 17 2015 Fedora Release Engineering <rel-eng.org> - 1.8.0-6 - Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild
My rephrasing of the orignal bug report: Package is built with gssapi support because configure is not finding the implementation. Please add --with-gssapi-impl=mit to ./configure flags.
Anything I can do to get this landed?
(In reply to Paul Belanger from comment #9) > Anything I can do to get this landed? Hello, Paul. I've just added you as a co-maintainer. Sorry for the delay.
*** Bug 1134957 has been marked as a duplicate of this bug. ***