Description of problem:

We are seeing that RHEL 6.6 kickstart repository is viewed as 'successful' even though the distribution files failed to sync.  This causes us to fail as we proceed with the deployment.

I'm suggesting we update the code to check the return value of sync_complete to look at the error details.



RHCI deployment proceeds and results in error:
 
  NoMethodError: undefined method `bootable_distribution' for nil:NilClass

/opt/rh/ruby193/root/usr/share/gems/gems/fusor_server-0.0.1/app/lib/actions/fusor/configure_host_groups.rb:271:in `find_operating_system'
/opt/rh/ruby193/root/usr/share/gems/gems/fusor_server-0.0.1/app/lib/actions/fusor/configure_host_groups.rb:92:in `find_or_ensure_hostgroup'
/opt/rh/ruby193/root/usr/share/gems/gems/fusor_server-0.0.1/app/lib/actions/fusor/configure_host_groups.rb:41:in `block in run'
/opt/rh/ruby193/root/usr/share/gems/gems/fusor_server-0.0.1/app/lib/actions/fusor/configure_host_groups.rb:40:in `each'
/opt/rh/ruby193/root/usr/share/gems/gems/fusor_server-0.0.1/app/lib/actions/fusor/configure_host_groups.rb:40:in `run'
/opt/rh/ruby193/root/usr/share/gems/gems/dynflow-0.7.7.7/lib/dynflow/action.rb:481:in `block (3 levels) in execute_run'


Below is what I see from /var/log/foreman/production.log for the sync status

2015-07-22 17:03:23 [I] Processing by Katello::Api::V2::RepositoriesController#sync_complete as JSON
2015-07-22 17:03:23 [I]   Parameters: {"call_report"=>"[FILTERED]", "event_type"=>"repo.sync.finish", "payload"=>{"importer_id"=>"yum_importer", "exception"=>nil, "repo_id"=>"Default_Organization-Red_Hat_Enterprise_Linux_Server-Red_Hat_Enterprise_Linux_6_Server_Kickstart_x86_64_6_6", "traceback"=>nil, "started"=>"2015-07-22T20:50:45Z", "_ns"=>"repo_sync_results", "completed"=>"2015-07-22T21:03:22Z", "importer_type_id"=>"yum_importer", "error_message"=>nil, "summary"=>{"content"=>{"state"=>"FINISHED"}, "comps"=>{"state"=>"FINISHED"}, "distribution"=>{"state"=>"FAILED"}, "errata"=>{"state"=>"FINISHED"}, "metadata"=>{"state"=>"FINISHED"}}, "added_count"=>3996, "result"=>"success", "updated_count"=>2, "details"=>{"content"=>{"size_total"=>3470962080, "items_left"=>0, "items_total"=>3783, "state"=>"FINISHED", "size_left"=>0, "details"=>{"rpm_total"=>3783, "rpm_done"=>3783, "drpm_total"=>0, "drpm_done"=>0}, "error_details"=>[]}, "comps"=>{"state"=>"FINISHED"}, "distribution"=>{"items_total"=>1847, "state"=>"FAILED", "error_details"=>[["https://cdn.redhat.com/content/dist/rhel/server/6/6.6/x86_64/kickstart/repodata/32423e1e0951479f0721239a9b3028afe2edd81d113062504a2f4feb4860b874-filelists.xml.gz", {"response_code"=>404, "response_msg"=>"Not Found"}], ["https://cdn.redhat.com/content/dist/rhel/server/6/6.6/x86_64/kickstart/repodata/2efbe9020f8fc2c2259e58653ff6c36c931f14f21590d441621ed09d46e562f4-other.sqlite.bz2", {"response_code"=>404, "response_msg"=>"Not Found"}], ["https://cdn.redhat.com/content/dist/rhel/server/6/6.6/x86_64/kickstart/repodata/6221039e7e3dabf7d538c76571d82aaf42b6292b8f6fe6cf56b8fcf1cff3d3ab-comps-rhel6-Server.xml", {"response_code"=>404, "response_msg"=>"Not Found"}], ["https://cdn.redhat.com/content/dist/rhel/server/6/6.6/x86_64/kickstart/repodata/73f064f26711880e0087a719eb9c5ab413278449d91b085c70bc44e3ee67c5c5-primary.sqlite.bz2", {"response_code"=>404, "response_msg"=>"Not Found"}], ["https://cdn.redhat.com/content/dist/rhel/server/6/6.6/x86_64/kickstart/repodata/0df25bc891cf4fe556465fc69e7a7c23ead0e3a277824757c1318bf3a20cc1bc-filelists.sqlite.bz2", {"response_code"=>404, "response_msg"=>"Not Found"}], ["https://cdn.redhat.com/content/dist/rhel/server/6/6.6/x86_64/kickstart/repodata/fb0e5677e7d538677ba416288d95a51b6507ae719517f4277a67ba0019f3cf60-other.xml.gz", {"response_code"=>404, "response_msg"=>"Not Found"}], ["https://cdn.redhat.com/content/dist/rhel/server/6/6.6/x86_64/kickstart/repodata/ba938f3c38a940b42f213f3281963151b563b790a90fb52bd759e44ecb08998d-comps-rhel6-Server.xml.gz", {"response_code"=>404, "response_msg"=>"Not Found"}], ["https://cdn.redhat.com/content/dist/rhel/server/6/6.6/x86_64/kickstart/repodata/c4dc485ed5f6176d27c1102e248105c684da554ab0c944f375102f108d235edc-primary.xml.gz", {"response_code"=>404, "response_msg"=>"Not Found"}]], "items_left"=>0}, "errata"=>{"state"=>"FINISHED"}, "metadata"=>{"state"=>"FINISHED"}}, "id"=>"55b0051a30b04210e5c08a8e", "removed_count"=>0}, "token"=>"5j5apE33PgqMtATGeBwCNhHsYarMdht7", "api_version"=>"v2", "repository"=>{}}
2015-07-22 17:03:23 [I] Sync_complete called for Red Hat Enterprise Linux 6 Server Kickstart x86_64 6.6, running after_sync.