Bug 1246383 - exo-open fails with url encoded file paths
Summary: exo-open fails with url encoded file paths
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: exo
Version: 22
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1246346 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-07-24 07:55 UTC by Paul DeStefano
Modified: 2015-08-25 16:07 UTC (History)
4 users (show)

Fixed In Version: 0.10.6-4.fc23
Clone Of:
Environment:
Last Closed: 2015-08-21 03:49:14 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Xfce 12017 0 None None None Never

Description Paul DeStefano 2015-07-24 07:55:09 UTC
Description of problem:
xdg-open forgot how to parse file:// URLs, correctly.  For example, it doesn't know what %20 means

Version-Release number of selected component (if applicable):
xdg-utils-1.1.0-0.39.rc3.fc22.noarch

How reproducible:
Always since F22

Steps to Reproduce:
1. touch "/tmp/space name.txt"
2. xdg-open 'file:///tmp/space%20name.txt'
3.

Actual results:
Error when getting information for file '/tmp/space%20name.txt': No such file or directory.

Expected results:
file should open

Additional info:
Calibre owner says this is the root cause of bug 1246346

Comment 1 Zbigniew Jędrzejewski-Szmek 2015-07-24 13:02:45 UTC
*** Bug 1246346 has been marked as a duplicate of this bug. ***

Comment 2 Paul DeStefano 2015-07-29 18:21:21 UTC
Yeah, I guess that's okay, except that my Calibre library is nearly *unusable* now, while xdg-open still works in other situations.  So, I'm worried this isn't going to get fixed.  Calibre is severely impacted, while only one feature of xdg-open is broken.

Comment 3 Rex Dieter 2015-07-29 18:25:53 UTC
Under what DE are you seeing this?

It works for me on kde, ie,
kde-open 'file:///tmp/space%20name.txt'
works

Comment 4 Rex Dieter 2015-07-29 18:38:21 UTC
And what does this say with your test-case?

XDG_UTILS_DEBUG_LEVEL=2 xdg-open 'file:///tmp/space%20name.txt'

Comment 5 Paul DeStefano 2015-07-30 03:51:31 UTC
$ XDG_UTILS_DEBUG_LEVEL=2 xdg-open 'file:///tmp/space%20name.txt'
Selected DE xfce

I'm using Xfce.

What does kde-open have to do with it?  Why didn't you try xdg-open?  kde-open isn't even part of the xdg-utils package.

Comment 6 Rex Dieter 2015-07-30 13:40:15 UTC
(I did try xdg-open, it worked the same way for me, because xdg-open is essentially just a wrapper for DE-specific tools.

Now, in your case, all xdg-open does on xfce is pass the input on to xfce's exo-open.  It appears that exo-open is failing here, and seemingly not able to handle encoded url's

# works
$ exo-open '/tmp/space name.txt'
$ exo-open file:///tmp/space\ name.txt
$ exo-open 'file:///tmp/space name.txt'


# does not work
$ exo-open 'file:///tmp/space%20name.txt'



exo maintainer(s), is this a bug or feature?  If not a bug, we'll probably have to modify xdg-open to not try using exo-open anymore.

Comment 7 Kevin Fenzi 2015-07-30 16:43:09 UTC
Bug. 

https://bugzilla.xfce.org/show_bug.cgi?id=12017

I'll see about making a scratch build with the patch to test later unless someone beats me to it. ;)

Comment 8 Rex Dieter 2015-07-30 16:58:23 UTC
thanks (updating summary)

Comment 9 Paul DeStefano 2015-07-30 17:26:41 UTC
(In reply to Rex Dieter from comment #6)
> (I did try xdg-open, it worked the same way for me, because xdg-open is
> essentially just a wrapper for DE-specific tools.

Ah, right, sorry!  I did learn that at some point in the past; I just forgot.

Thanks!

Comment 10 Kevin Fenzi 2015-07-31 19:35:35 UTC
Can you please try this scratch build and let me know if it fixes the issue?

https://koji.fedoraproject.org/koji/taskinfo?taskID=10563906

Comment 11 Paul DeStefano 2015-08-03 05:55:31 UTC
Hi Kevin,

Thanks for the new build so quick.

I think I did it right, but I got the same error, so let me tell you what I did.

1) downloaded the rpm exo-0.10.6-4.fc22.x86_64.rpm from koji (from you src build task)
2) installed it with 'rpm -Uvh ...rpm'
3) tried it with 'exo-open "file:///home/.../onea%20two.txt"'

This gives a dialog box with

Error when getting information for file '/home/pdestefa/tmp/exoProblem/one%20two.txt': No such file or directory.

So, that is the same as before.

Comment 12 Kevin Fenzi 2015-08-03 14:44:08 UTC
Bah. 

Try this build:

https://koji.fedoraproject.org/koji/taskinfo?taskID=10587846

Any better?

Comment 13 Paul DeStefano 2015-08-05 00:09:27 UTC
Yes!  Works on my exo-open and xdg-open tests.  And, better yet, it fixed my Calibre library.  (I don't know why having Calibre misbehave was so uncomfortable, but it really was.)

Thanks much!

Comment 14 Fedora Update System 2015-08-05 15:34:30 UTC
exo-0.10.6-4.fc23 has been submitted as an update for Fedora 23.
https://admin.fedoraproject.org/updates/exo-0.10.6-4.fc23

Comment 15 Fedora Update System 2015-08-05 15:34:49 UTC
exo-0.10.6-4.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/exo-0.10.6-4.fc22

Comment 16 Fedora Update System 2015-08-06 16:00:58 UTC
Package exo-0.10.6-4.fc23:
* should fix your issue,
* was pushed to the Fedora 23 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing exo-0.10.6-4.fc23'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-12859/exo-0.10.6-4.fc23
then log in and leave karma (feedback).

Comment 17 Fedora Update System 2015-08-21 03:49:13 UTC
exo-0.10.6-4.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2015-08-25 16:07:19 UTC
exo-0.10.6-4.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.