Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1246589

Summary:	we specify 3 dhcp_agents_per_network when there is only 1 controller
Product:	Red Hat OpenStack	Reporter:	Marios Andreou <mandreou>
Component:	python-tripleoclient	Assignee:	Marios Andreou <mandreou>
Status:	CLOSED ERRATA	QA Contact:	Marius Cornea <mcornea>
Severity:	unspecified	Docs Contact:
Priority:	high
Version:	7.0 (Kilo)	CC:	achernet, dmacpher, hbrock, jslagle, mandreou, mburns, rhel-osp-director-maint
Target Milestone:	---	Keywords:	Triaged, ZStream
Target Release:	8.0 (Liberty)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-tripleoclient-0.0.11-5.el7ost	Doc Type:	Bug Fix
Doc Text:	In older deployments using the python-rdomanager-oscplugin (not the python-tripleoclient) for Overcloud deployment, the dhcp_agents_per_network parameter for neutron was set to a minimum of 3, even in the case of a non-HA single controller deployment. This meant the dhcp_agents_per_network was set to 3 when deploying with only 1 Controller. This fix takes into account the single Controller case. The director sets at most 3 dhcp_agents_per_network and never more than the number of Controllers. Now if you deploy in HA with 3 or more controller nodes, the dhcp_agents_per_network configuration parameter in neutron.conf on those Controller nodes will be set to '3'. Alternatively if you deploy in non-HA with only 1 Controller, this same dhcp_agents_per_network parameter will be set to '1'.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-04-07 21:38:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Marios Andreou 2015-07-24 15:51:47 UTC

Description of problem:
When we deploy 1 controller, we set dhcp_agents_per_network to 3, like
[1]. We do this because marios (the silly git) misinterpreted Assaf Muller's suggested
"min(3, num_of_controllers)" as "at minimum three" (we were previously
always statically setting this to 2 in all cases, including 1 controller at that point anyway).

[1]
https://github.com/rdo-management/python-rdomanager-oscplugin/blob/1f4c92fc23f14503ef68511c54d9f1519efdacf4/rdomanager_oscplugin/v1/overcloud_deploy.py#L327

Version-Release number of selected component (if applicable):


How reproducible:
Easily. Deploy a 1 controller overcloud and you will see that 

/etc/neutron/neutron.conf:243:dhcp_agents_per_network = 3

on that controller.

Steps to Reproduce:
1. openstack overcloud deploy --plan overcloud --control-scale 1 --compute-scale 1
2. ssh heat-admin@controller-ip; sudo su; grep -rni 'dhcp_agents_per' /etc/neutron/*
3. profit (in the 1 controller case you still get 3 dhcp_agents_per_network).

Actual results:
/etc/neutron/neutron.conf:243:dhcp_agents_per_network = 3

Expected results:
/etc/neutron/neutron.conf:243:dhcp_agents_per_network = 1

Additional info:
The fix for this is already available and has been tested at https://review.gerrithub.io/#/c/241104

Comment 3 Mike Burns 2015-08-19 16:25:48 UTC

Is this still an issue? or did we end up fixing it?

Comment 5 Marios Andreou 2015-08-24 10:58:15 UTC

(In reply to Mike Burns from comment #3)
> Is this still an issue? or did we end up fixing it?

no we are still setting to three afaics in the rdomanager plugin code

Comment 6 Marios Andreou 2015-09-07 12:12:07 UTC

so the fix for this was at https://review.gerrithub.io/#/c/241104 -  this is a downstream only fix since it is in the rdomanager plugin. That was abandoned because the fix was included in https://review.gerrithub.io/#/c/241111/. 

In the end neither of these landed. I tried reviving the /#/c/241104 but failed (marked as closed and i am not gfidente), so I opened a new review at https://review.gerrithub.io/#/c/246108 rebased against master and also pointing here.

thanks.

Comment 7 Marios Andreou 2015-09-08 16:41:22 UTC

upstream review @ https://review.openstack.org/#/c/221398/ and bug report at https://bugs.launchpad.net/tripleo/+bug/1493445

Comment 11 Marius Cornea 2016-03-02 10:53:53 UTC

python-tripleoclient-0.1.1-4.el7ost.noarch

[root@overcloud-controller-0 heat-admin]# grep -rni 'dhcp_agents_per' /etc/neutron/*
/etc/neutron/neutron.conf:262:# dhcp_agents_per_network = 1
/etc/neutron/neutron.conf:263:dhcp_agents_per_network = 1

Comment 13 errata-xmlrpc 2016-04-07 21:38:25 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-0604.html