Spec URL: https://salimma.fedorapeople.org/specs/python/python-hypothesis.spec SRPM URL: https://salimma.fedorapeople.org/specs/python/python-hypothesis-1.8.2-1.fc22.src.rpm Description: Hypothesis is a library for testing your Python code against a much larger range of examples than you would ever want to write by hand. It’s based on the Haskell library, Quickcheck, and is designed to integrate seamlessly into your existing Python unit testing work flow. Fedora Account System Username: salimma
General comment: The spec file looks reasonable, but I wonder is there ever a reason you wouldn't want to compile python2 & 3 versions? If not then it would let us remove all the conditionals.
Created attachment 1055867 [details] build.log There's a build failure on my local machine.
(In reply to Richard W.M. Jones from comment #1) > General comment: The spec file looks reasonable, but I wonder is > there ever a reason you wouldn't want to compile python2 & 3 versions? > If not then it would let us remove all the conditionals. Good question. On EPEL7, perhaps? The limitation of Python3 builds to take place only on Fedora is inherited from the Python template rpmdev-newspec uses; I'll try and build on EPEL7 and remove the conditionals if it works. The test failure is interesting - that test case times out after 2 seconds. What sort of hardware are you running on? (Build finishes fine on my Core i5-3230M laptop). Getting late here, will push an updated SRPM tomorrow and try building on Koji too. I got upstream to push missing tags -- previously PyPI was already at 1.8.4 but the last tagged version on GitHub was 1.8.2, but now 1.8.5 is actually out and tagged: https://github.com/DRMacIver/hypothesis/issues/107
EPEL7 doesn't have a Python 3 stack - for simplicity let's target Fedora only at the moment. I've removed the conditionals; Koji scratch build of 1.8.5 here: http://koji.fedoraproject.org/koji/taskinfo?taskID=10467387 Will be updating the spec to turn on documentation generation, and then get to the other review.
Spec URL: https://salimma.fedorapeople.org/specs/python/python-hypothesis.spec SRPM URL: https://salimma.fedorapeople.org/specs/python/python-hypothesis-1.8.5-2.fc22.src.rpm - Update to 1.8.5 - Make Python3 build unconditional - Remove she-bang from tools/mergedbs.py - Include manpage
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MPL (v2.0)", "Unknown or generated". 10 files have unknown license. Detailed output of licensecheck in /tmp/1246598-python- hypothesis/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package - Assuming this doesn't apply to Python packages. [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. - All automatically generated. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. [-]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-hypothesis-1.8.5-2.fc24.noarch.rpm python3-hypothesis-1.8.5-2.fc24.noarch.rpm python-hypothesis-1.8.5-2.fc24.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- python-hypothesis (rpmlib, GLIBC filtered): python(abi) python3-hypothesis (rpmlib, GLIBC filtered): python(abi) Provides -------- python-hypothesis: python-hypothesis python3-hypothesis: python3-hypothesis Source checksums ---------------- https://github.com/DRMacIver/hypothesis/archive/v1.8.5.tar.gz#/hypothesis-1.8.5.tar.gz : CHECKSUM(SHA256) this package : e36064ec0e3803007b57118b49c6c1939a1d2df04f00b864ce0b3cd5c4eefaa1 CHECKSUM(SHA256) upstream package : e36064ec0e3803007b57118b49c6c1939a1d2df04f00b864ce0b3cd5c4eefaa1 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1246598 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 =================== Looks good to me. This package is APPROVED by rjones.
Many thanks! New Package SCM Request ======================= Package Name: python-hypothesis Short Description: A library for property based testing Upstream URL: https://github.com/DRMacIver/hypothesis Owners: salimma Branches: f21 f22 f23 InitialCC:
Git done (by process-git-requests).
python-hypothesis-1.10.0-1.fc23 has been submitted as an update for Fedora 23. https://admin.fedoraproject.org/updates/python-hypothesis-1.10.0-1.fc23
python-hypothesis-1.10.0-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-hypothesis-1.10.0-1.fc22
python-hypothesis-1.10.0-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-hypothesis-1.10.0-1.fc21
python-hypothesis-1.10.0-1.fc23 has been pushed to the Fedora 23 testing repository.
python-hypothesis-1.10.0-1.fc22 has been pushed to the Fedora 22 stable repository.
python-hypothesis-1.10.0-1.fc23 has been pushed to the Fedora 23 stable repository.
python-hypothesis-1.10.0-1.fc21 has been pushed to the Fedora 21 stable repository.