Bug 1246657 - Review Request: nodejs-lower-case-first - Lower case the first character of a string
Summary: Review Request: nodejs-lower-case-first - Lower case the first character of a...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-07-24 19:42 UTC by Piotr Popieluch
Modified: 2015-08-08 01:08 UTC (History)
2 users (show)

Fixed In Version: nodejs-lower-case-first-1.0.0-1.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-08-08 01:08:56 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Piotr Popieluch 2015-07-24 19:42:54 UTC
Spec URL: https://piotrp.fedorapeople.org/nodejs-lower-case-first-1.0.0-1.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-lower-case-first-1.0.0-1.fc24.src.rpm
Description: Lower case the first character of a string
Fedora Account System Username: piotrp

Comment 2 Parag AN(पराग) 2015-07-25 04:23:57 UTC
Review:

+ Package koji scratch build successful F24 (x86_64)

+ rpmlint on all generated rpms gave output
nodejs-lower-case-first.noarch: W: spelling-error %description -l en_US toString -> to String, to-string, stringing
nodejs-lower-case-first.noarch: W: spelling-error %description -l en_US booleans -> boo leans, boo-leans, Boolean
nodejs-lower-case-first.noarch: W: only-non-binary-in-usr-lib
nodejs-lower-case-first.noarch: W: dangling-symlink /usr/lib/node_modules/lower-case-first/node_modules/lower-case /usr/lib/node_modules/lower-case
nodejs-lower-case-first.src: W: spelling-error %description -l en_US toString -> to String, to-string, stringing
nodejs-lower-case-first.src: W: spelling-error %description -l en_US booleans -> boo leans, boo-leans, Boolean
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

+ Source verified with upstream as (sha256sum)
upstream source: cdf2a179aaf84fd3f2f1ebff66ba9e5b52477b6ba6a19f04f6ec6591ef49fdb2
source in srpm : cdf2a179aaf84fd3f2f1ebff66ba9e5b52477b6ba6a19f04f6ec6591ef49fdb2

+ License "MIT" is valid and included in its own file LICENSE.

+ rest follows nodejs packaging guidelines

APPROVED.

Comment 3 Piotr Popieluch 2015-07-25 10:23:18 UTC
Thank you!

New Package SCM Request
=======================
Package Name: nodejs-lower-case-first
Short Description: Lower case the first character of a string
Upstream URL: https://github.com/blakeembrey/lower-case-first
Owners: piotrp
Branches: f21 f22 f23 epel7

Comment 4 Gwyn Ciesla 2015-07-27 19:28:53 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2015-07-29 20:15:17 UTC
nodejs-lower-case-first-1.0.0-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/nodejs-lower-case-first-1.0.0-1.fc22

Comment 6 Fedora Update System 2015-07-30 13:54:18 UTC
nodejs-lower-case-first-1.0.0-1.fc22 has been pushed to the Fedora 22 testing repository.

Comment 7 Fedora Update System 2015-08-08 01:08:56 UTC
nodejs-lower-case-first-1.0.0-1.fc22 has been pushed to the Fedora 22 stable repository.


Note You need to log in before you can comment on or make changes to this bug.