Spec URL: https://jsbackus.fedorapeople.org/lua-argparse/lua-argparse.spec SRPM URL: https://jsbackus.fedorapeople.org/lua-argparse/lua-argparse-0.4.0-1.fc22.src.rpm Description: Argparse is a feature-rich command line parser for Lua inspired by argparse for Python. Argparse supports positional arguments, options, flags, optional arguments, subcommands and more. Argparse automatically generates usage, help and error messages. Fedora Account System Username: jsbackus
Koji Builds: * Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=10471251 * F23: http://koji.fedoraproject.org/koji/taskinfo?taskID=10471257 * F22: http://koji.fedoraproject.org/koji/taskinfo?taskID=10471260 * F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=10471263 * EPEL7: http://koji.fedoraproject.org/koji/taskinfo?taskID=10471269
Hi Christopher, Thanks for being willing to review my package! I found a couple of little problems while tinkering with another package of mine, so I have updated the spec to: * Apply proper permissions to the installed .lua file. (Fixes an error regarding executable script...) * Removed the commented-out %check section. I'll have to add that if the requisite software ever makes it into Fedora. * Added proper handling of the license for EPEL6. Updated spec and SRPM: * https://jsbackus.fedorapeople.org/lua-argparse/lua-argparse.spec * https://jsbackus.fedorapeople.org/lua-argparse/lua-argparse-0.4.0-2.fc22.src.rpm Koji Builds: * F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=10582876 * F22: http://koji.fedoraproject.org/koji/taskinfo?taskID=10582880 * F23: http://koji.fedoraproject.org/koji/taskinfo?taskID=10582884 * Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=10582888 Regards, Jeff
Ahhh! Wrong package. Koji Builds: * F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=10580403 * F22: http://koji.fedoraproject.org/koji/taskinfo?taskID=10580409 * F23: http://koji.fedoraproject.org/koji/taskinfo?taskID=10580415 * Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=10580423 * EPEL7: http://koji.fedoraproject.org/koji/taskinfo?taskID=10580431 * EPEL6: http://koji.fedoraproject.org/koji/taskinfo?taskID=10580438
You can use %{!?_licensedir:%global license %%doc} at the top of the spec then just use %license without issues.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 10 files have unknown license. Detailed output of licensecheck: Unknown or generated -------------------- argparse-75a765623d2269acda3ec429a26c7fde007bf542/.travis_setup.sh argparse-75a765623d2269acda3ec429a26c7fde007bf542/.travis_setup_rocks.sh argparse-75a765623d2269acda3ec429a26c7fde007bf542/doc/_static/doctools.js argparse-75a765623d2269acda3ec429a26c7fde007bf542/doc/_static/jquery.js argparse-75a765623d2269acda3ec429a26c7fde007bf542/doc/_static/js/theme.js argparse-75a765623d2269acda3ec429a26c7fde007bf542/doc/_static/searchtools.js argparse-75a765623d2269acda3ec429a26c7fde007bf542/doc/_static/underscore.js argparse-75a765623d2269acda3ec429a26c7fde007bf542/doc/_static/websupport.js argparse-75a765623d2269acda3ec429a26c7fde007bf542/doc/searchindex.js argparse-75a765623d2269acda3ec429a26c7fde007bf542/docsrc/conf.py [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in lua- argparse-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: lua-argparse-0.4.0-2.fc24.noarch.rpm lua-argparse-doc-0.4.0-2.fc24.noarch.rpm lua-argparse-0.4.0-2.fc24.src.rpm lua-argparse.noarch: W: spelling-error %description -l en_US subcommands -> sub commands, sub-commands, commands lua-argparse-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/lua-argparse-doc/_static/jquery.js lua-argparse.src: W: spelling-error %description -l en_US subcommands -> sub commands, sub-commands, commands 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- lua-argparse-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/lua-argparse-doc/_static/jquery.js 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Requires -------- lua-argparse-doc (rpmlib, GLIBC filtered): lua-argparse (rpmlib, GLIBC filtered): lua(abi) Provides -------- lua-argparse-doc: lua-argparse-doc lua-argparse: lua-argparse Source checksums ---------------- https://github.com/mpeterv/argparse/archive/75a765623d2269acda3ec429a26c7fde007bf542/lua-argparse-0.4.0.tar.gz : CHECKSUM(SHA256) this package : b9d31f09ffcb7cfed1c9ebd981e06d6c576e4ee01d6f333bb62162b3f30e158b CHECKSUM(SHA256) upstream package : b9d31f09ffcb7cfed1c9ebd981e06d6c576e4ee01d6f333bb62162b3f30e158b Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/bin/fedora-review -rvn lua-argparse-0.4.0-2.fc22.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -------------------------------------------------------- 1. You directly copy docs to final package, it's better to regenerate them from source to avoid crlf problem, and please drop the bundled fonts. 2. Ask upstream to add license header to argparse.lua since it's the only useful source we can have. 3. Comment 4 can ease your life XD
Hi Christopher, Thanks! Yes, comment 4 is *much* cleaner. :) I've made the requested changes. Here's the updated package: * Spec: https://jsbackus.fedorapeople.org/lua-argparse/lua-argparse.spec * SRPM: https://jsbackus.fedorapeople.org/lua-argparse/lua-argparse-0.4.0-3.fc22.src.rpm Koji Builds: * F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=10606478 * F22: http://koji.fedoraproject.org/koji/taskinfo?taskID=10606501 * F23: http://koji.fedoraproject.org/koji/taskinfo?taskID=10606505 * Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=10606511 Regards, Jeff
Hi Christopher, Upstream has released an update with the license included at the top of argparse.lua. Here's the updated package: * Spec: https://jsbackus.fedorapeople.org/lua-argparse/lua-argparse.spec * SRPM: https://jsbackus.fedorapeople.org/lua-argparse/lua-argparse-0.4.1-1.fc22.src.rpm Koji Builds: * F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=10650927 * F22: http://koji.fedoraproject.org/koji/taskinfo?taskID=10650929 * F23: http://koji.fedoraproject.org/koji/taskinfo?taskID=10650931 * Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=10650933 Regards, Jeff
PACKAGE APPROVED.
Great, thanks Christopher!
New Package SCM Request ======================= Package Name: lua-argparse Short Description: Feature-rich command line parser for Lua Upstream URL: https://github.com/mpeterv/argparse Owners: jsbackus Branches: f21 f22 f23 el6 epel7 InitialCC:
Git done (by process-git-requests).