Spec URL: https://mmckinst.fedorapeople.org/packages/emacs-yaml-mode/emacs-yaml-mode.spec SRPM URL: https://mmckinst.fedorapeople.org/packages/emacs-yaml-mode/emacs-yaml-mode-0.0.11-1.fc21.src.rpm Description: Major mode to edit YAML file for emacs Fedora Account System Username: mmckinst
scratch f22 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10580201
mmckinst's scratch build of emacs-yaml-mode-0.0.12-1.fc21.src.rpm for f21 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11315931
updated to 0.0.12: spec: https://mmckinst.fedorapeople.org/packages/emacs-yaml-mode/emacs-yaml-mode.spec src.rpm: https://mmckinst.fedorapeople.org/packages/emacs-yaml-mode/emacs-yaml-mode-0.0.12-1.fc21.src.rpm scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=11316127 copr: http://copr.fedoraproject.org/coprs/mmckinst/emacs-yaml-mode/build/123602/
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later) (with incorrect FSF address)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/gil/1247442-emacs-yaml-mode/licensecheck.txt [-]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/emacs/site-lisp/yaml-mode [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/emacs/site-lisp /yaml-mode [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: emacs-yaml-mode-0.0.12-1.fc24.noarch.rpm emacs-yaml-mode-0.0.12-1.fc24.src.rpm emacs-yaml-mode.noarch: E: incorrect-fsf-address /usr/share/emacs/site-lisp/yaml-mode/yaml-mode.el 2 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: File o directory non esistente emacs-yaml-mode.noarch: E: incorrect-fsf-address /usr/share/emacs/site-lisp/yaml-mode/yaml-mode.el 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Requires -------- emacs-yaml-mode (rpmlib, GLIBC filtered): emacs(bin) Provides -------- emacs-yaml-mode: emacs-yaml-mode Source checksums ---------------- https://github.com/yoshiki/yaml-mode/archive/v0.0.12.tar.gz : CHECKSUM(SHA256) this package : f294ed0e2f77081c2e77fd9bd9b496346d5812b240613c5c9aee2dc6abfa5ca1 CHECKSUM(SHA256) upstream package : f294ed0e2f77081c2e77fd9bd9b496346d5812b240613c5c9aee2dc6abfa5ca1 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1247442 -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Issues: [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/emacs/site-lisp /yaml-mode [!]: Uses parallel make %{?_smp_mflags} macro. [!]: Packages should try to preserve timestamps of original installed files. in makefile INSTALL constant should be /usr/bin/install -c -pm 444 install -m 644 %SOURCE1 %{buildroot}%{_emacs_sitestartdir} should be install -pm 644 %SOURCE1 %{buildroot}%{_emacs_sitestartdir} NON blocking issues: [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Package does not include license text files separate from upstream. Please, ask to upstream to include copy of the license in source directory structure https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text emacs-yaml-mode.noarch: E: incorrect-fsf-address /usr/share/emacs/site-lisp/yaml-mode/yaml-mode.el Please, report the problem to upstream https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
Regarding the three issues, they have been fixed. Regarding the old FSF address and lack of license text in the upstream project: https://github.com/yoshiki/yaml-mode/pull/36 spec: https://mmckinst.fedorapeople.org/packages/emacs-yaml-mode/emacs-yaml-mode.spec srpm: https://mmckinst.fedorapeople.org/packages/emacs-yaml-mode/emacs-yaml-mode-0.0.12-2.fc22.src.rpm copr: https://copr.fedoraproject.org/coprs/mmckinst/emacs-yaml-mode/build/151018/
now seem all ok Approved
Thanks gil! I'll get bookkeeper taken care of today.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/emacs-yaml-mode
emacs-yaml-mode-0.0.12-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-30239cc04d
emacs-yaml-mode-0.0.12-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-560f9e3096
emacs-yaml-mode-0.0.12-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-00cfa78a3b
emacs-yaml-mode-0.0.12-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-00cfa78a3b
emacs-yaml-mode-0.0.12-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-278606100f
emacs-yaml-mode-0.0.12-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-560f9e3096
emacs-yaml-mode-0.0.12-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-30239cc04d
emacs-yaml-mode-0.0.12-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
emacs-yaml-mode-0.0.12-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
emacs-yaml-mode-0.0.12-2.el5 has been submitted as an update to Fedora EPEL 5. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-1b94744ebc
emacs-yaml-mode-0.0.12-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-1b94744ebc
emacs-yaml-mode-0.0.12-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
emacs-yaml-mode-0.0.12-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
emacs-yaml-mode-0.0.12-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.