Red Hat Bugzilla – Bug 1247737
turbostat 1.2-7 man page verbose flag incorrect
Last modified: 2016-05-10 16:29:05 EDT
Description of problem: upgrading to turbostat 1.2-7 in RHEL6.7 changed the -v flag from 'verbose' to 'version', but the man page was not updated. Version-Release number of selected component (if applicable): upgrading from turbostat 1.2-5 to 1.2-7 How reproducible: 100% Steps to Reproduce: 1. run 'turbostat -v', it will return the version information, not put the command in verbose mode. Actual results: Below is a partial diff of the changed code: + case 'D': + dump_only++; break; - case 'v': - verbose++; + case 'd': + debug++; break; ... - default: - usage(); + case 'v': + print_version(); + exit(0); + break Expected results: Man page should reflect program behavior. Additional info:
way too late for 6.7, needs to wait for 6.8
Heh, we just had a mid-air collision as I was setting the flags for 6.8. That should be fine.
Created attachment 1058111 [details] new turbostat man page Dow that look about right to you Frank?
Looks correct to me. Too bad they removed the 'verbose' flag completely.
ok, I'll commit this if it gets approved for 6.8
ACK, it looks fine to me.
Hi Neil, there is no '-v' parameter mentioned neither in the man page nor in turbostat --help output. So is isn't misleading now. My personal opinion is, that all existing parameters should be described in the man page. OTOH I can accept is as deprecated parameter and let is pass. What do you think about?
# turbostat --help 2>&1|grep -- '-v' --version print version information # man turbostat|grep -- '-v' --version displays the version. # turbostat -v sleep 1 turbostat version 4.8 26-Sep, 2015 - Len Brown <lenb@kernel.org>
yes, please accept it as deprecated
O.K., thanks for the info.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-0785.html