Description of problem: Report an unclear error while set password for a non-exsitent user inside the guest Version-Release number of selected component (if applicable): kernel-3.10.0-300.el7.x86_64 libvirt-1.2.17-2.el7.x86_64 qemu-kvm-rhev-2.3.0-13.el7.x86_64 guest info qemu-guest-agent-2.3.0-2.el7.x86_64.rpm How reproducible: 100% Steps to Reproduce: 1.Prepare a running guest with guest agent installed 2.Get selinux to permissive mode since bug 1243458 haven't fixed yet #setenforce 0 # getenforce Permissive 3.Set password for a non-exsitent user inside the guest, will get an unclear error,this info should be improved # virsh set-user-password virt-tests-vm1 --user user1 --password redhat error: internal error: unable to execute QEMU agent command 'guest-set-user-password': child process has failed to set user password Actual results: report an unclear error while set password for a non-exsitent user inside the guest Expected results: should get clear error info, such as "user user1 didn't exsit" Additional info:
this is really minor and perhaps wontfix: if it fails to set password it is very likely because the user didn't exist, so the generic error is enough. Parsing chpasswd error output is cumbersome and could potentially break on various systems or updates. Daniel, since you implemented it, I suppose you came to similar conclusion?
Yeah, I don't think it is worth the complexity to try to parse chpassword output here, the generic error is sufficient IMHO.
agree, let's close as wontfix then