Bug 1248090 - Tasks drawer doesn't display jobs/step tree correctly
Summary: Tasks drawer doesn't display jobs/step tree correctly
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-webadmin
Version: 3.6
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.6.0
Assignee: Moti Asayag
QA Contact: Petr Kubica
URL:
Whiteboard: infra
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-07-29 15:01 UTC by Shmuel Melamud
Modified: 2016-02-10 19:30 UTC (History)
12 users (show)

Fixed In Version: 3.6.0-12
Clone Of:
Environment:
Last Closed: 2015-11-04 11:25:53 UTC
oVirt Team: Infra
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 45547 0 master MERGED engine: Revert JPA Never
oVirt gerrit 45586 0 ovirt-engine-3.6 MERGED engine: Revert JPA Never

Description Shmuel Melamud 2015-07-29 15:01:25 UTC
Description of problem:

"Tasks" drawer at the bottom of the webadmin should display tree of jobs, steps and substeps. But currently, it displays substeps several times - once in the correct place in the tree and also on all previous levels. The corresponding structure in the DB is correct.

Also, when user click on "+" to open a branch, it closes shortly, so it's practically impossible to open the whole tree.

How reproducible:
100%

Steps to Reproduce:
1. Create a VM pool with one or several VMs.
2. Open the "Tasks" drawer at the bottom.

Actual results:
The drawer shows steps and substeps mixed. The topmost job "Creating VM Pool" contains several Validating, Executing and Finalizing steps and so on.

Expected results:
The drawer shows the correct jobs/steps tree.

Additional info:

Comment 1 Oved Ourfali 2015-07-30 07:00:31 UTC
Shmuel - I guess you refer to recursive hierarchy?
Moti - do we support recursiveness there?

Comment 2 Shmuel Melamud 2015-07-30 10:17:13 UTC
(In reply to Oved Ourfali from comment #1)
> Shmuel - I guess you refer to recursive hierarchy?

Yes.

Comment 3 Moti Asayag 2015-08-02 10:53:52 UTC
(In reply to Oved Ourfali from comment #1)
> Shmuel - I guess you refer to recursive hierarchy?
> Moti - do we support recursiveness there?

yes, the steps are implemented as a composite pattern - each step may have sub steps.

There were few changes around the fetch method of sub-steps by commit:
92dca0ea7fff25c8e8e8e509241df1158928e180

Is it possible to verify the same scenario before that commit was introduced ?

Comment 4 Oved Ourfali 2015-08-05 05:43:35 UTC
Liran - please sync with Moti on that one, and check it out.

Comment 5 Petr Kubica 2015-09-15 08:38:35 UTC
Verified in 3.6.0-0.15.master.el6

Comment 6 Sandro Bonazzola 2015-11-04 11:25:53 UTC
oVirt 3.6.0 has been released on November 4th, 2015 and should fix this issue.
If problems still persist, please open a new BZ and reference this one.


Note You need to log in before you can comment on or make changes to this bug.