From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5)
Gecko/20031007

Description of problem:
When building the XFree86 package with:

#> rpm --rebuild XFree86-4.1.0-58.EL.src.rpm

The updated S3 Savagee driver (1.1.27t) is copied in to the incorrect
directory, which means that the updated driver will not be compiled
and built in to the rpm package.

The savage driver used during the build is located in the 
/usr/src/redhat/BUILD/XFree86-4.1.0/xc/programs/Xserver/hw/xfree86/drivers/savage
directory, the updated driver is extracted into the 
/usr/src/redhat/BUILD/XFree86-4.1.0/xc/programs/Xserver/hw/xfree86/drivers/savage/savage
directory, which the compile will ignore, the end reslut is that the
original 1.1.16 driver will be compiled instead of the updated 1.1.27t
driver.

The extraction routine in the SPEC file is as follows:
# Drop in Savage driver update:
{
   echo "Applying SAVAGE driver tarball"
   pushd xc/programs/Xserver/hw/xfree86/drivers/savage
   tar zxvf %{SOURCE14}
   popd
}

Changing the pushd line to:
pushd xc/programs/Xserver/hw/xfree86/drivers
will extract the driver into the correct folder, and the build process
will compile and build the correct driver version.

This happens bcause the driver package extracts the files to a
directory instead of directly into the target directory.

Note that the original XFree86-4.1.0-58.EL.i386.rpm is also using the
original savage driver (1.1.16), I expect that the intention was to
use updated driver when building the RPM's for XFree86.

Version-Release number of selected component (if applicable):
XFree86-4.1.0-58.EL

How reproducible:
Always

Steps to Reproduce:
1.Install and rebuild source RPM
2.Verify driver level after install with:
#> strings /usr/X11R6/lib/modules/drivers/savage_drv.o |grep version
3.
    

Additional info:

Note that the updated driver is required to fix issues with the S3
savage driver, only safe option on some systems is to run without a GUI.