Spec URL: https://gil.fedorapeople.org/jaxb2-basics-annotate.spec SRPM URL: https://gil.fedorapeople.org/jaxb2-basics-annotate-1.0.1-1.fc22.src.rpm Description: JAXB2 Annotate Plugin adds arbitrary annotations to Java classes generated by JAXB/XJC. Fedora Account System Username: gil Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10558628
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 5 files have unknown license. jaxb2-annotate-plugin-1.0.1/plugin/src/main/java/org/jvnet/jaxb2_commons/plugin/annotate/AnnotatePlugin.java jaxb2-annotate-plugin-1.0.1/plugin/src/main/java/org/jvnet/jaxb2_commons/plugin/annotate/AnnotatingArrayValueVisitor.java jaxb2-annotate-plugin-1.0.1/plugin/src/main/java/org/jvnet/jaxb2_commons/plugin/annotate/AnnotatingSingleValueVisitor.java jaxb2-annotate-plugin-1.0.1/plugin/src/main/java/org/jvnet/jaxb2_commons/plugin/annotate/AnnotatingVisitor.java jaxb2-annotate-plugin-1.0.1/plugin/src/main/java/org/jvnet/jaxb2_commons/plugin/annotate/Annotator.java Please contact upstream to clarify licensing. Best if they put proper license header and release new version. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jaxb2 -basics-annotate-javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: jaxb2-basics-annotate-1.0.1-1.fc24.noarch.rpm jaxb2-basics-annotate-javadoc-1.0.1-1.fc24.noarch.rpm jaxb2-basics-annotate-1.0.1-1.fc24.src.rpm jaxb2-basics-annotate.src: W: strange-permission jaxb2-basics-annotate.spec 600 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- jaxb2-basics-annotate-javadoc (rpmlib, GLIBC filtered): jpackage-utils jaxb2-basics-annotate (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.jvnet.annox:annox) mvn(org.jvnet.jaxb2_commons:jaxb2-basics-tools) Provides -------- jaxb2-basics-annotate-javadoc: jaxb2-basics-annotate-javadoc jaxb2-basics-annotate: jaxb2-basics-annotate mvn(org.jvnet.jaxb2_commons:jaxb2-annotate-plugin-project:pom:) mvn(org.jvnet.jaxb2_commons:jaxb2-basics-annotate) mvn(org.jvnet.jaxb2_commons:jaxb2-basics-annotate:pom:) Source checksums ---------------- https://github.com/highsource/jaxb2-annotate-plugin/archive/1.0.1.tar.gz : CHECKSUM(SHA256) this package : b714867312d2d9806f4c80aa15853e66a91aed37e2dc5e77cf976fd9d69a7ad9 CHECKSUM(SHA256) upstream package : b714867312d2d9806f4c80aa15853e66a91aed37e2dc5e77cf976fd9d69a7ad9 This is my first review, here are some small extra comments: > find -name "*.class" -print -delete Not needed, upstream does not include .class files > find -name "*.jar" -print -delete Not needed, upstream does not include .jar files > rm -r plugin/src/test/java/org/jvnet/jaxb2_commons/plugin/annotate/tests/RunPlugin.java -r flag is not needed
(In reply to Jonny Heggheim from comment #1) > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated". 5 files have unknown license. > jaxb2-annotate-plugin-1.0.1/plugin/src/main/java/org/jvnet/jaxb2_commons/ > plugin/annotate/AnnotatePlugin.java > jaxb2-annotate-plugin-1.0.1/plugin/src/main/java/org/jvnet/jaxb2_commons/ > plugin/annotate/AnnotatingArrayValueVisitor.java > jaxb2-annotate-plugin-1.0.1/plugin/src/main/java/org/jvnet/jaxb2_commons/ > plugin/annotate/AnnotatingSingleValueVisitor.java > jaxb2-annotate-plugin-1.0.1/plugin/src/main/java/org/jvnet/jaxb2_commons/ > plugin/annotate/AnnotatingVisitor.java > jaxb2-annotate-plugin-1.0.1/plugin/src/main/java/org/jvnet/jaxb2_commons/ > plugin/annotate/Annotator.java > > Please contact upstream to clarify licensing. Best if they put proper > license header and release new version. Done https://github.com/highsource/jaxb2-annotate-plugin/issues/12 > This is my first review, here are some small extra comments: > > find -name "*.class" -print -delete > Not needed, upstream does not include .class files > > > find -name "*.jar" -print -delete > Not needed, upstream does not include .jar files > > > rm -r plugin/src/test/java/org/jvnet/jaxb2_commons/plugin/annotate/tests/RunPlugin.java > -r flag is not needed
There need something else? You can proceed with the review? Thanks
> Done https://github.com/highsource/jaxb2-annotate-plugin/issues/12 Great.
> There need something else? You can proceed with the review? I would like that you reply to my extra comments.
(In reply to Jonny Heggheim from comment #5) > > There need something else? You can proceed with the review? > I would like that you reply to my extra comments. If that's not an issue I leave it as it is
> If that's not an issue I leave it as it is I am the newbie. If it is not important, then that is valuable knowledge for me.
Approved
Thanks! New Package SCM Request ======================= Package Name: jaxb2-annotate-plugin Short Description: Plugin that add arbitrary annotations to JAXB classes Upstream URL: https://github.com/highsource/jaxb2-annotate-plugin Owners: gil InitialCC: java-sig
WARNING: Requested package name jaxb2-annotate-plugin doesn't match bug summary jaxb2-basics-annotate
New Package SCM Request ======================= Package Name: jaxb2-annotate-plugin Short Description: Plugin that add arbitrary annotations to JAXB classes Upstream URL: https://github.com/highsource/jaxb2-annotate-plugin Owners: gil InitialCC: java-sig
New Package SCM Request ======================= Package Name: jaxb2-basics-annotate Short Description: Plugin that add arbitrary annotations to JAXB classes Upstream URL: https://github.com/highsource/jaxb2-annotate-plugin Owners: gil InitialCC: java-sig
Git done (by process-git-requests).
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10778621