Bug 1249211 - Review Request: cndoom - Conservative Doom engine for speedrunning competition
Summary: Review Request: cndoom - Conservative Doom engine for speedrunning competition
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rahul Sundaram
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-07-31 19:48 UTC by Adam Williamson
Modified: 2018-02-15 02:17 UTC (History)
3 users (show)

(edit)
Clone Of:
(edit)
Last Closed:


Attachments (Terms of Use)

Description Adam Williamson 2015-07-31 19:48:43 UTC
Spec URL: https://www.happyassassin.net/reviews/cndoom/cndoom.spec
SRPM URL: Spec URL: https://www.happyassassin.net/reviews/cndoom/cndoom-2.0.3.2-1.fc23.src.rpm
Description: Conservative Doom engine for speedrunning competition
Fedora Account System Username: adamwill

Comment 1 Adam Williamson 2015-07-31 19:49:59 UTC
Hey Rahul, Ankur - either of you feel like taking this? It's based on chocolate-doom, which Rahul packaged and Ankur reviewed. The build is very similar. Thanks!

Comment 2 Adam Williamson 2015-07-31 21:25:54 UTC
Updated to -2: rename some manpages not to conflict with chocolate-doom.

A thought occurs: should we have a small noarch package which owns /usr/share/doom and installs /etc/profile.d/doom.{csh,sh} to set DOOMWADDIR and DOOMWADPATH? http://doomwiki.org/wiki/Environment_variables

then all compliant ports could depend on it, and would find freedoom automatically if it's installed. I was gonna add a file like that to cndoom, but it seems to make more sense as something shared.

Comment 3 Rahul Sundaram 2015-08-12 14:53:45 UTC
I will try and do this tonight.

Comment 4 Rahul Sundaram 2015-09-02 00:03:39 UTC
I will post more notes later:

cndoom.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/cndoom/ChangeLog
cndoom.x86_64: E: invalid-desktopfile /usr/share/applications/cnsetup.desktop value "Settings" for string list key "Categories" in group "Desktop Entry" does not have a semicolon (';') as trailing character
cndoom.x86_64: W: desktopfile-without-binary /usr/share/applications/cnsetup.desktop cnsetup
cndoom.src:23: W: unversioned-explicit-provides bundled(sha1-gnupg)

I would welcome the common noarch package and can take patches to spec file if necessary and/or feel free to become a co-maintainer.

Comment 5 Ankur Sinha (FranciscoD) 2018-01-07 22:51:15 UTC
Two years later.. 

Adam, if you're still interested in this, I'd be happy to take the review over?

Cheers!

Comment 6 Adam Williamson 2018-01-08 19:37:37 UTC
Er, possibly, let's leave it open for a bit and I'll see if I get a minute to get around to it. Thanks!

Comment 7 Adam Williamson 2018-02-15 02:17:45 UTC
Quick update - the github repo disappeared. The author is still active on Doomworld forums, I've sent him a message asking what's going on.


Note You need to log in before you can comment on or make changes to this bug.