Bug 1250102 - [RFE] - Show user/group icons in search results for users
Summary: [RFE] - Show user/group icons in search results for users
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 3.6.0
Hardware: Unspecified
OS: Unspecified
Target Milestone: ovirt-4.0.0-alpha
: 4.0.0
Assignee: Alexander Wels
QA Contact: Pavel Novotny
Depends On:
TreeView+ depends on / blocked
Reported: 2015-08-04 14:09 UTC by David Jaša
Modified: 2016-08-01 12:27 UTC (History)
9 users (show)

Fixed In Version: ovirt 4.0.0 alpha1
Doc Type: Enhancement
Doc Text:
Clone Of:
Last Closed: 2016-08-01 12:27:19 UTC
oVirt Team: Infra
rule-engine: ovirt-4.0.0+
pnovotny: testing_plan_complete-
rule-engine: planning_ack+
ecohen: devel_ack+
pstehlik: testing_ack+

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
oVirt gerrit 49111 0 master MERGED webadmin: Split users and groups 2016-01-11 18:20:53 UTC

Description David Jaša 2015-08-04 14:09:04 UTC
Description of problem:
In all the Users/Permissions tabs, there are nice icons distinguishing users from groups. It would be helpful to display them in user search results as well.

Version-Release number of selected component (if applicable):
oVirt 3.6 alpha 2

How reproducible:

Steps to Reproduce:
1. go to Users tab, Add user dialog, search for a user so that both user(s) and group(s) are returned

Actual results:
no distiction is made 

Expected results:
user or group icon is displayed as is Users/Permissions tab

Additional info:

Comment 1 Oved Ourfali 2015-08-12 06:21:06 UTC
Einav - do you consider this an RFE? Is that something to be done in 3.6?

Comment 2 Einav Cohen 2015-08-12 10:29:18 UTC
(In reply to Oved Ourfali from comment #1)
> Einav - do you consider this an RFE? Is that something to be done in 3.6?

this definitely an improvement, at least. should most likely be resolved post 3.6.

Comment 3 Alexander Wels 2015-09-30 14:34:35 UTC
So after configuring LDAP in 3.6 and doing some test runs, I have come to the conclusion that adding the icon would be a minor improvement but not really solve the real problem.

The real problem is that the group result set doesn't line up with the user result set. So I would like to propose a change to the RFE to solve the real issue.

1. Add a radio button to allow the user to either pick group/users. It is highly likely the admin that is adding the user/group will know which one they are adding.
2. Based on the selection of the radio button change the grid columns to show the appropriate column information:
  a. Users:
    1. User name. Maybe add first name/last name in parenthesis?
    2. principal name.
    3. email address.
  b. Groups:
    1. Group name.
    2. ???

Right now we are doing 2 queries to the LDAP server, one for the users and one for the groups. This proposal will eliminate one request per search, as we will be searching one or the other.

Let me know what you think of this proposal, it will add a little more work to the rfe, but will improve the experience significantly for the admin IMO

Comment 4 Einav Cohen 2015-09-30 23:07:40 UTC
Hi Alexander, the suggestion sounds good - please note that I prefer to keep it consistent with the view of the main Users grid. 
The main Users grid currently displays both Users and Groups [http://i.imgur.com/6YGmCPM.png]. However, I've just noticed that for a group (e.g. "Everyone"), the group name is displayed in the 'First Name' column (just like in the Add Permission dialog), which is a bit misleading. 

It may make sense to apply your radio-buttons solution to both the Add Permission dialog and the Users main grid - but for the main grid, need to see how this will "play nice" with the Search mechanism (we have a similar functionality in e.g. the Disks main tab that we may be able to use as a reference). Can you please look into that?

Comment 5 Red Hat Bugzilla Rules Engine 2015-12-01 15:36:16 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 6 Pavel Novotny 2016-07-28 15:57:15 UTC
Verified in 

Instead of icons in one data grid, the Users -> Add dialog now has a radio button with choices User / Group which splits the search for users or groups only.
User option then sets the results table header to First Name, Last name, User Name.
Group option sets the header to Group Name, Display Name.

Note You need to log in before you can comment on or make changes to this bug.