Bug 1250257 - Review Request: python-pid - PID file management library
Summary: Review Request: python-pid - PID file management library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Igor Gnatenko
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-08-04 21:07 UTC by David Shea
Modified: 2015-08-27 19:39 UTC (History)
2 users (show)

Fixed In Version: python-pid-2.0.1-2.fc23
Clone Of:
Environment:
Last Closed: 2015-08-10 10:11:26 UTC
Type: ---
Embargoed:
ignatenko: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description David Shea 2015-08-04 21:07:42 UTC
Spec URL: https://dshea.fedorapeople.org/python-pid/python-pid.spec
SRPM URL: https://dshea.fedorapeople.org/python-pid/python-pid-2.0.1-1.fc22.src.rpm
Description: pid provides a PidFile class that manages PID files. PidFile features:
  - stale detection
  - locking using fcntl
  - chmod (default is 0o644)
  - chown
  - custom exceptions

PidFile can also be used as a context manager or a decorator.

Fedora Account System Username: dshea

Comment 1 Igor Gnatenko 2015-08-04 21:31:46 UTC
https://fedoraproject.org/wiki/User:Tibbs/PythonCleanup2

* use %py2_build/%py3_build instead of %{__pythonX} setup.py blahblah
* provide python2 and python3 subpackage at the same time and use %python_provide there
* don't need to have 2 separate directories to build py2/py3 version

All other cheks looks good.

I've fixed all issues here: https://ignatenkobrain.fedorapeople.org/for-review/python-pid.spec

If you agree with my new spec -- please build SRPM for it, provide links and I will approve.

Comment 2 Igor Gnatenko 2015-08-04 21:41:38 UTC
P.S. new python guidelines just pushed there: https://fedoraproject.org/wiki/Packaging:Python

Comment 3 David Shea 2015-08-04 22:21:21 UTC
I really wish that FPC or whoever would make up their minds on all this junk. Thank you for making the changes.

SRPM URL: https://dshea.fedorapeope.org/python-pid/python-pid-2.0.1-2.fc22.src.rpm
Spec URL: https://dshea.fedorapeople.org/python-pid/python-pid.spec

Comment 4 Igor Gnatenko 2015-08-05 04:10:16 UTC
APPROVED.

David, feel free to add me to maintainers :)

Comment 5 David Shea 2015-08-05 12:17:30 UTC
New Package SCM Request
=======================
Package Name: python-pid
Short Description: PID file management library
Upstream URL: https://pypi.python.org/pypi/pid
Owners: dshea
Branches: f23
InitialCC:

Comment 6 Gwyn Ciesla 2015-08-05 13:31:02 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2015-08-05 17:55:17 UTC
python-pid-2.0.1-2.fc23 has been submitted as an update for Fedora 23.
https://admin.fedoraproject.org/updates/python-pid-2.0.1-2.fc23

Comment 8 Fedora Update System 2015-08-06 16:00:05 UTC
python-pid-2.0.1-2.fc23 has been pushed to the Fedora 23 testing repository.

Comment 9 Fedora Update System 2015-08-10 10:11:26 UTC
python-pid-2.0.1-2.fc23 has been pushed to the Fedora 23 stable repository.

Comment 10 David Shea 2015-08-27 18:17:53 UTC
Package Change Request
======================
Package Name: python-pid
New Branches: f22
Owners: dshea
InitialCC: 

Request to add f22 branch which will make it easier to use development versions of blivet-gui from F22 live CDs.

Comment 11 Gwyn Ciesla 2015-08-27 19:39:30 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.