Bug 1250884 - Review Request: future - Easy, clean, reliable Python 2/3 compatibility
Summary: Review Request: future - Easy, clean, reliable Python 2/3 compatibility
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: noarch
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Susmit
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1393502 (view as bug list)
Depends On:
Blocks: 1250887
TreeView+ depends on / blocked
 
Reported: 2015-08-06 08:41 UTC by Antonio T. (sagitter)
Modified: 2016-11-09 20:39 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-09-25 07:57:51 UTC
Type: ---
Embargoed:
thinklinux.ssh: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Antonio T. (sagitter) 2015-08-06 08:41:38 UTC
Spec URL: https://sagitter.fedorapeople.org/future/future.spec
SRPM URL: https://sagitter.fedorapeople.org/future/future-0.15.0-2.fc22.src.rpm

Description: future is the missing compatibility layer between Python 2 and
Python 3. It allows you to use a single, clean Python 3.x-compatible
codebase to support both Python 2 and Python 3 with minimal overhead.

It provides ``future`` and ``past`` packages with backports and forward
ports of features from Python 3 and 2. It also comes with ``futurize`` and
``pasteurize``, customized 2to3-based scripts that helps you to convert
either Py2 or Py3 code easily to support both Python 2 and 3 in a single
clean Py3-style codebase, module by module.

Fedora Account System Username: sagitter

Note.
1- Package for Fedora, EPEL6, EPEL7
2- This packages provides PEM certificates in future/backports/test directory
   It's for testing purpose, i guess they can be ignored according to 'rpmlint' info.

Comment 1 Susmit 2015-08-25 22:57:15 UTC
python packaging guideline[1] says:

If you build for more than one python runtime you must use the %python_provide macro.

Can you please address this?

https://fedoraproject.org/wiki/Packaging:Python#Multiple_Python_Runtimes

Comment 2 Antonio T. (sagitter) 2015-09-02 10:05:45 UTC
Spec URL: https://sagitter.fedorapeople.org/future/future.spec
SRPM URL: https://sagitter.fedorapeople.org/future/future-0.15.0-4.fc22.src.rpm

- Added patch to exclude failed tests (patch0)
- Added python-provides macro

Comment 3 Antonio T. (sagitter) 2015-09-11 17:55:17 UTC
Spec URL: https://sagitter.fedorapeople.org/future/future.spec
SRPM URL: https://sagitter.fedorapeople.org/future/future-0.15.2-1.fc22.src.rpm

- Update to 0.15.2

Comment 4 Antonio T. (sagitter) 2015-09-14 08:16:44 UTC
Please, kindly consider this ticket; i need complete this review as soon as possible because other packages are stalled by it.

Comment 5 Susmit 2015-09-14 16:38:39 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

    [x]: The package must be named according to the Package Naming Guidelines .
    [x]: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption..
    [x]: The package must meet the Packaging Guidelines .
    [x]: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
    [x]: The License field in the package spec file must match the actual license.
    [x]: The spec file must be written in American English.
    [x]: The spec file for the package MUST be legible.
    [x]: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
    [x]: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
    [x]: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line.
    [x]: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
    [x]: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
    [-]: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun.
    [x]: Packages must NOT bundle copies of system libraries.
    [-]: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker.
    [x]: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)
    [x]: Permissions on files must be set properly. Executables should be set with executable permissions, for example.
    [x]: Each package must consistently use macros.
    [x]: The package must contain code, or permissible content.
    [x]: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity).
    [x]: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.
    [-]: Static libraries must be in a -static package.
    [-]: Development files must be in a -devel package.
   [-]: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release}
    [-]: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
    [-]: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section.
    [+]: Packages must not own files or directories already owned by other packages.
    [+]: All filenames in rpm packages must be valid UTF-8.


Python:
    [+]: If you build for more than one python runtime you must use the %python_provide macro.
    [+]: Python modules must be built from source. They cannot simply drop an egg from upstream into the proper directory. (See prebuilt binaries Guidelines for details)
    [+]: Python modules must not download any dependencies during the build process.
    [-]: When building a compat package, it must install using easy_install -m so it won't conflict with the main package.
    [-]: When building multiple versions (for a compat package) one of the packages must contain a default version that is usable via "import MODULE" with no prior setup.


===== SHOULD items =====

    [+]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
    [+]: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available.
    [?]: The reviewer should test that the package builds in mock.
    [?]: The package should compile and build into binary rpms on all supported architectures.
    [+]: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example.
    [-]: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity.
    [-]: Usually, subpackages other than devel should require the base package using a fully versioned dependency.
    [-]: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb.
    [-]: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself.
    [+]: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense.
    [-]: A package which is used by another package via an egg interface should provide egg info.

===== EXTRA items =====

    [x]: Rpmlint is run on all installed packages.
    [x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
$ rpmlint future-0.15.2-1.fc22.src.rpm
future.src: W: spelling-error %description -l en_US codebase -> co debase, co-debase, code base
future.src: W: spelling-error %description -l en_US backports -> back ports, back-ports, crackpots
future.src: W: spelling-error %description -l en_US futurize -> futurist
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

Comment 6 Antonio T. (sagitter) 2015-09-14 16:51:25 UTC
Thanks.

New Package SCM Request
=======================
Package Name: future
Short Description: Easy, clean, reliable Python 2/3 compatibility
Upstream URL: http://python-future.org/
Owners: sagitter
Branches: f22 f23 el6 epel7

Comment 7 Gwyn Ciesla 2015-09-14 17:52:03 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2015-09-15 14:35:32 UTC
future-0.15.2-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15908

Comment 9 Fedora Update System 2015-09-15 14:35:32 UTC
future-0.15.2-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15909

Comment 10 Fedora Update System 2015-09-15 14:37:40 UTC
future-0.15.2-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8090

Comment 11 Fedora Update System 2015-09-15 14:37:41 UTC
future-0.15.2-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8089

Comment 12 Fedora Update System 2015-09-15 16:50:14 UTC
future-0.15.2-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update future'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15908

Comment 13 Fedora Update System 2015-09-15 22:56:15 UTC
future-0.15.2-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update future'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15909

Comment 14 Fedora Update System 2015-09-16 00:20:15 UTC
future-0.15.2-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update future'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8090

Comment 15 Fedora Update System 2015-09-17 01:52:19 UTC
future-0.15.2-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update future'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8089

Comment 16 Fedora Update System 2015-09-25 07:57:49 UTC
future-0.15.2-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2015-09-25 10:53:37 UTC
future-0.15.2-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2015-10-02 22:25:02 UTC
future-0.15.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 19 Fedora Update System 2015-10-02 23:23:14 UTC
future-0.15.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.

Comment 20 Ralph Bean 2016-11-09 20:39:31 UTC
*** Bug 1393502 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.