1251886 – virDomainAddIOThread allow add iothread 0 which make guest have a broken settings

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1251886 - virDomainAddIOThread allow add iothread 0 which make guest have a broken settings

Summary: virDomainAddIOThread allow add iothread 0 which make guest have a broken sett...

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	libvirt
Sub Component:
Version:	7.2
Hardware:	x86_64
OS:	Linux
Priority:	medium
Severity:	medium
Target Milestone:	rc
Target Release:	---
Assignee:	John Ferlan
QA Contact:	Virtualization Bugs
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2015-08-10 08:42 UTC by Luyao Huang
Modified:	2015-11-19 06:50 UTC (History)
CC List:	6 users (show)
Fixed In Version:	libvirt-1.2.17-6.el7
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:	2015-11-19 06:50:35 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2015:2202	0	normal	SHIPPED_LIVE	libvirt bug fix and enhancement update	2015-11-19 08:17:58 UTC

Description Luyao Huang 2015-08-10 08:42:05 UTC

Description of problem:
virDomainAddIOThread allow add iothread 0 which make guest have a broken settings

Version-Release number of selected component (if applicable):

libvirt-1.2.17-4.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. prepare a guest
# virsh list 
 Id    Name                           State
----------------------------------------------------
 343   rhel7.0-rhel                   running


2. use python function addIOThread to add iothread 0:

# python
Python 2.7.5 (default, Sep  4 2014, 05:34:58) 
[GCC 4.8.2 20140120 (Red Hat 4.8.2-16)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import libvirt
>>> conn=libvirt.open()
>>> dom=conn.lookupByName("rhel7.0-rhel")
>>> dom.addIOThread(0)
0

3.
# virsh iothreadinfo rhel7.0-rhel
 IOThread ID     CPU Affinity   
---------------------------------------------------
 1               0-3
 2               0,2-3
 3               0-3
 0               0-3

4. restart libvirtd

# service libvirtd restart
Redirecting to /bin/systemctl restart  libvirtd.service

# virsh list 
 Id    Name                           State
----------------------------------------------------

and can find log in libvirtd.log:

2015-08-10 08:39:13.111+0000: 19847: error : virDomainIOThreadIDDefParseXML:13882 : XML error: invalid iothread 'id' value '0'


Actual results:
virDomainAddIOThread allow add iothread 0 which make guest have a broken settings


Expected results:
forbid add iothread 0 like deliotread

Additional info:

Comment 1 John Ferlan 2015-08-13 15:14:09 UTC

Posted some patches upstream:

http://www.redhat.com/archives/libvir-list/2015-August/msg00585.html

Comment 4 Han Han 2015-09-11 09:01:58 UTC

Hi John, I can reproduce the bug on libvirt-1.2.17-4.el7.x86_64
Verify it on libvirt-1.2.17-8.el7.x86_64


Steps to verify:
1. Prepare a runing guest
# virsh list
 Id    Name                           State
----------------------------------------------------
 13    t40                            running

2. Use python function addIOThread to add iothread 0:
# python
>>> import libvirt
>>> conn=libvirt.open()
>>> dom=conn.lookupByName("t40")
>>> dom.addIOThread(0)
libvirt: QEMU Driver error : invalid argument: invalid value of 0 for iothread_id
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib64/python2.7/site-packages/libvirt.py", line 515, in addIOThread
    if ret == -1: raise libvirtError ('virDomainAddIOThread() failed', dom=self)
libvirt.libvirtError: invalid argument: invalid value of 0 for iothread_id

3. Check iothreadinfo
# virsh iothreadinfo t40
No IOThreads found for the domain

4. Restart libvirtd and check virsh list
# systemctl restart libvirtd
# virsh list                          
 Id    Name                           State
----------------------------------------------------
 15    t40                            running

Comment 6 errata-xmlrpc 2015-11-19 06:50:35 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2202.html

Note You need to log in before you can comment on or make changes to this bug.