Bug 1252038 - Require or Recommend perl(Time::HiRes)
Summary: Require or Recommend perl(Time::HiRes)
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: perl-POE
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-08-10 14:17 UTC by Yanko Kaneti
Modified: 2015-08-10 14:59 UTC (History)
3 users (show)

Fixed In Version: perl-POE-1.367-5.fc24
Clone Of:
Environment:
Last Closed: 2015-08-10 14:53:14 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Yanko Kaneti 2015-08-10 14:17:29 UTC
Description of problem:
Recently koschei informed of a build failure for one of my perl packages
https://apps.fedoraproject.org/koschei/package/perl-POE-Component-Client-SMTP

The failure seems to have been triggered by the separation of Net::Ping from the main perl package which in turn meant there was no Time::HiRes in the build root, which in turn seems to trigger very random failures in the test scripts for POE::Componnent::Client::SMTP.

I don't know if the test scripts themselves are even expected to run with POE kernel working without Time::HiRes.

The recommendation in the POE manpages is to install Time::HiRes if available.

I'd suggest a Requires to avoid any ambiguities with Recommends:


Version-Release number of selected component (if applicable):
perl-POE-1.367-4.fc23.noarch

Comment 1 Petr Šabata 2015-08-10 14:46:51 UTC
Hmm, how did you figure it out?  I can't tell from the logs :)  Or is it just a random guess?

The Time::HiRes dependency is "highly recommended" but still optional.  I'd prefer Recommends over Requires now that we have these; however, I think recommended dependencies are ignored in koji at the time being.  That might and probably will change at some point.

If your module really requires high accuracy timers, it should depend on Timer::HiRes as well.  I would probably ask upstream in this case.

Comment 2 Petr Šabata 2015-08-10 14:53:14 UTC
Well, in the end I've decided to use Requires for consistency.
I may switch to weak dependencies in the future, though.

Comment 3 Yanko Kaneti 2015-08-10 14:59:34 UTC
Thanks. 
Figured it out empirically. The test themselves (which involve lots of poe tcp client talking to poe tcp server) behave rather differently without Time::HiRes, slowness and random failures...

I would be lost if I had to track what specifically fails without Time::HiRes.


Note You need to log in before you can comment on or make changes to this bug.