Bug 1252038 - Require or Recommend perl(Time::HiRes)
Require or Recommend perl(Time::HiRes)
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: perl-POE (Show other bugs)
rawhide
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Petr Šabata
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2015-08-10 10:17 EDT by Yanko Kaneti
Modified: 2015-08-10 10:59 EDT (History)
3 users (show)

See Also:
Fixed In Version: perl-POE-1.367-5.fc24
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2015-08-10 10:53:14 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Yanko Kaneti 2015-08-10 10:17:29 EDT
Description of problem:
Recently koschei informed of a build failure for one of my perl packages
https://apps.fedoraproject.org/koschei/package/perl-POE-Component-Client-SMTP

The failure seems to have been triggered by the separation of Net::Ping from the main perl package which in turn meant there was no Time::HiRes in the build root, which in turn seems to trigger very random failures in the test scripts for POE::Componnent::Client::SMTP.

I don't know if the test scripts themselves are even expected to run with POE kernel working without Time::HiRes.

The recommendation in the POE manpages is to install Time::HiRes if available.

I'd suggest a Requires to avoid any ambiguities with Recommends:


Version-Release number of selected component (if applicable):
perl-POE-1.367-4.fc23.noarch
Comment 1 Petr Šabata 2015-08-10 10:46:51 EDT
Hmm, how did you figure it out?  I can't tell from the logs :)  Or is it just a random guess?

The Time::HiRes dependency is "highly recommended" but still optional.  I'd prefer Recommends over Requires now that we have these; however, I think recommended dependencies are ignored in koji at the time being.  That might and probably will change at some point.

If your module really requires high accuracy timers, it should depend on Timer::HiRes as well.  I would probably ask upstream in this case.
Comment 2 Petr Šabata 2015-08-10 10:53:14 EDT
Well, in the end I've decided to use Requires for consistency.
I may switch to weak dependencies in the future, though.
Comment 3 Yanko Kaneti 2015-08-10 10:59:34 EDT
Thanks. 
Figured it out empirically. The test themselves (which involve lots of poe tcp client talking to poe tcp server) behave rather differently without Time::HiRes, slowness and random failures...

I would be lost if I had to track what specifically fails without Time::HiRes.

Note You need to log in before you can comment on or make changes to this bug.