RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1252082 - removing chaining database links trigger valgrind read errors
Summary: removing chaining database links trigger valgrind read errors
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: 389-ds-base
Version: 7.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Noriko Hosoi
QA Contact: Viktor Ashirov
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-08-10 16:39 UTC by Noriko Hosoi
Modified: 2020-09-13 20:55 UTC (History)
4 users (show)

Fixed In Version: 389-ds-base-1.3.4.0-11.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-11-19 11:43:58 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
valgrind.out (73.02 KB, text/plain)
2015-08-23 17:48 UTC, Viktor Ashirov 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Github 389ds 389-ds-base issues 1022 0 None closed removing chaining database links trigger valgrind read errors 2020-12-01 11:06:26 UTC
Red Hat Product Errata RHBA-2015:2351 0 normal SHIPPED_LIVE 389-ds-base bug fix and enhancement update 2015-11-19 10:28:44 UTC

Description Noriko Hosoi 2015-08-10 16:39:48 UTC 
This bug is created as a clone of upstream ticket:
https://fedorahosted.org/389/ticket/47686

While deleting a chainingdb database link we start calling that backend's callbacks, and one of those callbacks deletes other callbacks from that same callback list.

==16217== Invalid read of size 8
==16217==    at 0x4C713B9: dse_call_callback (dse.c:2555)
==16217==    by 0x4C70E31: dse_delete (dse.c:2439)
==16217==    by 0x4C652CB: op_shared_delete (delete.c:364)
==16217==    by 0x4C64AB4: do_delete (delete.c:128)
==16217==    by 0x415C00: connection_dispatch_operation (connection.c:650)
==16217==    by 0x417AB2: connection_threadmain (connection.c:2534)
==16217==    by 0x3A8D029A72: ??? (in /lib64/libnspr4.so)
==16217==    by 0x378E407850: start_thread (in /lib64/libpthread-2.12.so)
==16217==    by 0x378E0E890C: clone (in /lib64/libc-2.12.so)
==16217==  Address 0xaf3e1e8 is 56 bytes inside a block of size 64 free'd
==16217==    at 0x4A063F0: free (vg_replace_malloc.c:446)
==16217==    by 0x4C5FB24: slapi_ch_free (ch_malloc.c:363)
==16217==    by 0x4C6C572: dse_callback_delete (dse.c:265)
==16217==    by 0x4C6C80D: dse_callback_removefromlist (dse.c:350)
==16217==    by 0x4C7129D: dse_remove_callback (dse.c:2523)
==16217==    by 0x4C7152F: slapi_config_remove_callback (dse.c:2588)
==16217==    by 0x8CB62DB: cb_delete_monitor_callback (cb_monitor.c:260)
==16217==    by 0x4C713A3: dse_call_callback (dse.c:2548)
==16217==    by 0x4C70E31: dse_delete (dse.c:2439)
==16217==    by 0x4C652CB: op_shared_delete (delete.c:364)
==16217==    by 0x4C64AB4: do_delete (delete.c:128)
==16217==    by 0x415C00: connection_dispatch_operation (connection.c:650)
==16217==    by 0x417AB2: connection_threadmain (connection.c:2534)
==16217==    by 0x3A8D029A72: ??? (in /lib64/libnspr4.so)
==16217==    by 0x378E407850: start_thread (in /lib64/libpthread-2.12.so)
==16217==    by 0x378E0E890C: clone (in /lib64/libc-2.12.so)
==16217==
==16217== Thread 19:
==16217== Invalid read of size 8
==16217==    at 0x4C713B9: dse_call_callback (dse.c:2555)
==16217==    by 0x4C70F9E: dse_delete (dse.c:2465)
==16217==    by 0x4C652CB: op_shared_delete (delete.c:364)
==16217==    by 0x4C64AB4: do_delete (delete.c:128)
==16217==    by 0x415C00: connection_dispatch_operation (connection.c:650)
==16217==    by 0x417AB2: connection_threadmain (connection.c:2534)
==16217==    by 0x3A8D029A72: ??? (in /lib64/libnspr4.so)
==16217==    by 0x378E407850: start_thread (in /lib64/libpthread-2.12.so)
==16217==    by 0x378E0E890C: clone (in /lib64/libc-2.12.so)
==16217==  Address 0xcc6bf38 is 56 bytes inside a block of size 64 free'd
==16217==    at 0x4A063F0: free (vg_replace_malloc.c:446)
==16217==    by 0x4C5FB24: slapi_ch_free (ch_malloc.c:363)
==16217==    by 0x4C6C572: dse_callback_delete (dse.c:265)
==16217==    by 0x4C6C80D: dse_callback_removefromlist (dse.c:350)
==16217==    by 0x4C7129D: dse_remove_callback (dse.c:2523)
==16217==    by 0x4C7152F: slapi_config_remove_callback (dse.c:2588)
==16217==    by 0x8CB351E: cb_instance_delete_config_callback (cb_instance.c:1714)
==16217==    by 0x4C713A3: dse_call_callback (dse.c:2548)
==16217==    by 0x4C70F9E: dse_delete (dse.c:2465)
==16217==    by 0x4C652CB: op_shared_delete (delete.c:364)
==16217==    by 0x4C64AB4: do_delete (delete.c:128)
==16217==    by 0x415C00: connection_dispatch_operation (connection.c:650)
==16217==    by 0x417AB2: connection_threadmain (connection.c:2534)
==16217==    by 0x3A8D029A72: ??? (in /lib64/libnspr4.so)
Comment 1 mreynolds 2015-08-10 17:03:34 UTC 
Fixed upstream.

Issue is only detectable in valgrind.

Steps to reproduce:

[1]  Enable valgrind for DS, and start it
[2]  Create a database link:

ldapmodify ...

dn: cn=example_link,cn=chaining database,cn=plugins,cn=config
changetype: add
objectClass: top
objectClass: extensibleObject
objectClass: nsBackendInstance
cn: example_link
nsslapd-suffix: dc=example,dc=com
nsmultiplexorbinddn: uid=test,dc=example,dc=com
nsfarmserverurl: ldap://localhost:389/
nsmultiplexorcredentials: {AES-TUhNR0NTcUdTSWIzRFFFRkRUQm1NRVVHQ1NxR1NJYjNEUUV
 GRERBNEJDUmxObUk0WXpjM1l5MHdaVE5rTXpZNA0KTnkxaE9XSmhORGRoT0MwMk1ESmpNV014TUFB
 Q0FRSUNBU0F3Q2dZSUtvWklodmNOQWdjd0hRWUpZSVpJQVdVRA0KQkFFcUJCQnY1M2VNeTVuR0hZT
 WRCVXRUYkcxcA==}mzH2Saj9gPyeozCbe+QehQ==

dn: cn=dc\3Dexample\2Cdc\3Dcom,cn=mapping tree,cn=config
changetype: modify
add: nsslapd-backend
nsslapd-backend: example_link

dn: cn=dc\3Dexample\2Cdc\3Dcom,cn=mapping tree,cn=config
changetype: modify
delete: nsslapd-backend
nsslapd-backend: example_link


[3]  Delete the Link

ldapmodify ...

dn: cn=monitor,cn=example_link,cn=chaining database,cn=plugins,cn=config
changetype: delete

dn: cn=example_link,cn=chaining database,cn=plugins,cn=config
changetype: delete

[4]  Stop the server

[5]  Check there is nothing in the valgrind report mentioning "dse_call_callback" and "Invalid read"
Comment 3 Viktor Ashirov 2015-08-23 17:48:25 UTC 
Created attachment 1066067 [details]
valgrind.out

Build tested: 389-ds-base-1.3.4.0-13.el7.x86_64

I don't see any invalid reads with related dse_call_callback in the valgrind output. 

But there are plenty of these messages:
==20636==    by 0x4E917B8: dse_call_callback.isra.1 (dse.c:2634)

Mark, could you please confirm that they are unrelated? 
Thanks!
Comment 4 mreynolds 2015-08-25 15:41:05 UTC 
(In reply to Viktor Ashirov from comment #3)
> Created attachment 1066067 [details]
> valgrind.out
> 
> Build tested: 389-ds-base-1.3.4.0-13.el7.x86_64
> 
> I don't see any invalid reads with related dse_call_callback in the valgrind
> output. 
> 
> But there are plenty of these messages:
> ==20636==    by 0x4E917B8: dse_call_callback.isra.1 (dse.c:2634)
> 
> Mark, could you please confirm that they are unrelated? 
> Thanks!

Those are unrelated messages, and can be ignored.

Thanks,
Mark
Comment 5 Viktor Ashirov 2015-08-25 15:42:50 UTC 
Thanks, Mark!

Marking as VERIFIED.
Comment 6 errata-xmlrpc 2015-11-19 11:43:58 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2351.html
Note You need to log in before you can comment on or make changes to this bug.