Red Hat Bugzilla – Bug 1252823
Please include plugin script
Last modified: 2016-01-19 18:27:55 EST
In repack.sh you delete "elasticsearch elasticsearch.bat elasticsearch-service-mgr.exe elasticsearch-service-x64.exe elasticsearch-service-x86.exe plugin plugin.bat service.bat".
I understand what binaries must be stripped. But what with plugin, which is just shell script? I assume it is not sane way install such plugions which is not in rpm form, and it is main reason of excludin, is not? But may we let it on administrator choose when desired plugin is not packaged?
Could you please include that script in package as it done in upstream rpm?
I see how that could be useful. Jiri, what do you think?
I have nothing against adding shell for adding plugins. but...
Maybe I miss something, but upstream plugin.sh as it is, is unusable. We have to rewrite it from scratch or heavily patch to fit fedora installation. Same as was necessary with upstream launching script:(
Pavel, are you volunteer? I even dont knw how to test whether it works. I'm using elastic for really simple tasks so I'm happy with current state of things. If people needs more, they have to help. (as eg. zbyszek do)
Upstream rpm have everything in single directory. And all dependences built in. Fedora can't do that and upstream is exactly not cooperative...
Jiri thank you for the answer.
I'm use several plugins for elasticsearch like kopf, gui, Russian morphology, etc. Do we ever have some guidelines how to package such plugins for elastic in rpm?
And that is very useful even for Fedora installation install it as plugins via upstream mechanism. As I understand there only paths adjustment needed. Are you willing I try provide patch for that?
No guidelines at all :)
I can see are 2x2 approaches I would guess. I font know which will be more valid, so yours usecase - first usecase.
(global space plugin x user's space plugin) x (rpm packed plugin x upstream-like handled plugin)
I guess that global space + upstream-like handled would be most simple, but as I told. Your usecase is the way to go, as whole this thing is goig to evole...now. (and you may be the only user for some time...)
If you will try to provide patch, I will try to include it in RPMS:)
*** Bug 1226445 has been marked as a duplicate of this bug. ***
Proper solution for that should come from https://github.com/elastic/elasticsearch/issues/11797
Now I could provide simple solution requested initially. Please revisit attached patch. It also fixes bz#1296308 (which is very annoying even for tests).
Created attachment 1112248 [details]
Fix for 1252823 and 1296308 bugs
If you want I could push it myself.
I also request access to package to co-maintain it if you are willing.
Yup sure, I added you to maintainers. Go on and fix what you need. Considering it will be kept working :)
Sure I'll try be careful.
elasticsearch-1.7.1-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-1885bffc8c
elasticsearch-1.7.1-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-1885bffc8c
elasticsearch-1.7.1-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.