RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1253107 - blkiotune cannot live update <weight> value into domain xml via --weight
Summary: blkiotune cannot live update <weight> value into domain xml via --weight
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.3
Hardware: x86_64
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Pavel Hrdina
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks: 1288337 1305606 1313485
TreeView+ depends on / blocked
 
Reported: 2015-08-13 01:28 UTC by Pei Zhang
Modified: 2016-11-03 18:22 UTC (History)
6 users (show)

Fixed In Version: libvirt-1.3.1-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-03 18:22:36 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2016:2577 0 normal SHIPPED_LIVE Moderate: libvirt security, bug fix, and enhancement update 2016-11-03 12:07:06 UTC

Description Pei Zhang 2015-08-13 01:28:42 UTC
Description of problem:
blkiotune cannot live update <weight> value  into domain xml via --weight

Version-Release number of selected component (if applicable):
libvirt-1.2.17-4.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1.define and start a guest , get blkiotune as default

# virsh blkiotune r7
weight         : 1000
device_weight  :
device_read_iops_sec:
device_write_iops_sec:
device_read_bytes_sec:
device_write_bytes_sec:

2. set blkiotune with --weight
# virsh blkiotune r7 --weight 999

# virsh blkiotune r7
weight         : 999
device_weight  :
device_read_iops_sec:
device_write_iops_sec:
device_read_bytes_sec:
device_write_bytes_sec:

# virsh dumpxml r7|grep blkiotune
Nothing output .


3. define and start a guest like following
# virsh dumpxml r7-20 | grep blkiotune -A 5
  <blkiotune>
    <weight>888</weight>
    <device>
......

4.set blkiotune with --weight
# virsh blkiotune r7-20 --weight 999

# virsh blkiotune r7-20
weight         : 999
device_weight  :
device_read_iops_sec:
device_write_iops_sec:
device_read_bytes_sec:
device_write_bytes_sec:

# virsh dumpxml r7-20 | grep blkiotune -A 5
  <blkiotune>
    <weight>888</weight>  
    <device>
.....

check in cgroup , the value has been changed.
# cat /sys/fs/cgroup/blkio/machine.slice/machine-qemu\guest-name.scope/blkio.weight
999

Actual results:
As step2 and step4, the value of weight cannot be live updated.

Expected results:
I think the value of <weight> should be live updated.
If it's not (because the default value 1000 is not displayed in domain xml); perhaps It's better give some info in man page or libvirt.org.

Additional info:

Comment 1 Luyao Huang 2015-08-13 08:46:05 UTC
Send a patch to list:

https://www.redhat.com/archives/libvir-list/2015-August/msg00549.html

Comment 3 Pavel Hrdina 2015-11-12 11:20:59 UTC
Upstream commit:

commit bf2788218ad29719467260aa4ecad6dc31c97046
Author: Luyao Huang <lhuang>
Date:   Wed Aug 19 11:56:33 2015 +0800

    qemu: Update blkio.weight value after successful set
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1253107
    
    Make a call virCgroupGetBlkioWeight to re-read blkio.weight right
    after it is set in order to keep internal data up-to-date.
    
    Signed-off-by: Luyao Huang <lhuang>

Comment 5 Pei Zhang 2016-02-26 08:07:18 UTC
Verified version : 
libvirt-1.3.1-1.el7.x86_64

1.define and start a guest with blkiotune

# virsh dumpxml r72|grep blkiotune -A 4
  <blkiotune>
    <weight>999</weight>
  </blkiotune>

# virsh blkiotune r72 
weight         : 999
device_weight  : 
device_read_iops_sec: 
device_write_iops_sec: 
device_read_bytes_sec: 
device_write_bytes_sec: 

2.update --weight value

# virsh blkiotune r72 --weight 888

# virsh blkiotune r72 
weight         : 888
device_weight  : 
device_read_iops_sec: 
device_write_iops_sec: 
device_read_bytes_sec: 
device_write_bytes_sec: 

3.check in domain xml. It could be updated.
# virsh dumpxml r72|grep blkiotune -A 4
  <blkiotune>
    <weight>888</weight>
  </blkiotune>


4.check cgroup.
# cat /sys/fs/cgroup/blkio/machine.slice/machine-qemu\\x2dr72.scope/blkio.weight
888

Move to verified.

Comment 7 errata-xmlrpc 2016-11-03 18:22:36 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2577.html


Note You need to log in before you can comment on or make changes to this bug.