Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1253107 - blkiotune cannot live update <weight> value into domain xml via --weight
blkiotune cannot live update <weight> value into domain xml via --weight
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt (Show other bugs)
7.3
x86_64 Unspecified
medium Severity medium
: rc
: ---
Assigned To: Pavel Hrdina
Virtualization Bugs
:
Depends On:
Blocks: 1305606 1313485 1288337
  Show dependency treegraph
 
Reported: 2015-08-12 21:28 EDT by Pei Zhang
Modified: 2016-11-03 14:22 EDT (History)
6 users (show)

See Also:
Fixed In Version: libvirt-1.3.1-1.el7
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2016-11-03 14:22:36 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2016:2577 normal SHIPPED_LIVE Moderate: libvirt security, bug fix, and enhancement update 2016-11-03 08:07:06 EDT

  None (edit)
Description Pei Zhang 2015-08-12 21:28:42 EDT
Description of problem:
blkiotune cannot live update <weight> value  into domain xml via --weight

Version-Release number of selected component (if applicable):
libvirt-1.2.17-4.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1.define and start a guest , get blkiotune as default

# virsh blkiotune r7
weight         : 1000
device_weight  :
device_read_iops_sec:
device_write_iops_sec:
device_read_bytes_sec:
device_write_bytes_sec:

2. set blkiotune with --weight
# virsh blkiotune r7 --weight 999

# virsh blkiotune r7
weight         : 999
device_weight  :
device_read_iops_sec:
device_write_iops_sec:
device_read_bytes_sec:
device_write_bytes_sec:

# virsh dumpxml r7|grep blkiotune
Nothing output .


3. define and start a guest like following
# virsh dumpxml r7-20 | grep blkiotune -A 5
  <blkiotune>
    <weight>888</weight>
    <device>
......

4.set blkiotune with --weight
# virsh blkiotune r7-20 --weight 999

# virsh blkiotune r7-20
weight         : 999
device_weight  :
device_read_iops_sec:
device_write_iops_sec:
device_read_bytes_sec:
device_write_bytes_sec:

# virsh dumpxml r7-20 | grep blkiotune -A 5
  <blkiotune>
    <weight>888</weight>  
    <device>
.....

check in cgroup , the value has been changed.
# cat /sys/fs/cgroup/blkio/machine.slice/machine-qemu\guest-name.scope/blkio.weight
999

Actual results:
As step2 and step4, the value of weight cannot be live updated.

Expected results:
I think the value of <weight> should be live updated.
If it's not (because the default value 1000 is not displayed in domain xml); perhaps It's better give some info in man page or libvirt.org.

Additional info:
Comment 1 Luyao Huang 2015-08-13 04:46:05 EDT
Send a patch to list:

https://www.redhat.com/archives/libvir-list/2015-August/msg00549.html
Comment 3 Pavel Hrdina 2015-11-12 06:20:59 EST
Upstream commit:

commit bf2788218ad29719467260aa4ecad6dc31c97046
Author: Luyao Huang <lhuang@redhat.com>
Date:   Wed Aug 19 11:56:33 2015 +0800

    qemu: Update blkio.weight value after successful set
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1253107
    
    Make a call virCgroupGetBlkioWeight to re-read blkio.weight right
    after it is set in order to keep internal data up-to-date.
    
    Signed-off-by: Luyao Huang <lhuang@redhat.com>
Comment 5 Pei Zhang 2016-02-26 03:07:18 EST
Verified version : 
libvirt-1.3.1-1.el7.x86_64

1.define and start a guest with blkiotune

# virsh dumpxml r72|grep blkiotune -A 4
  <blkiotune>
    <weight>999</weight>
  </blkiotune>

# virsh blkiotune r72 
weight         : 999
device_weight  : 
device_read_iops_sec: 
device_write_iops_sec: 
device_read_bytes_sec: 
device_write_bytes_sec: 

2.update --weight value

# virsh blkiotune r72 --weight 888

# virsh blkiotune r72 
weight         : 888
device_weight  : 
device_read_iops_sec: 
device_write_iops_sec: 
device_read_bytes_sec: 
device_write_bytes_sec: 

3.check in domain xml. It could be updated.
# virsh dumpxml r72|grep blkiotune -A 4
  <blkiotune>
    <weight>888</weight>
  </blkiotune>


4.check cgroup.
# cat /sys/fs/cgroup/blkio/machine.slice/machine-qemu\\x2dr72.scope/blkio.weight
888

Move to verified.
Comment 7 errata-xmlrpc 2016-11-03 14:22:36 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2577.html

Note You need to log in before you can comment on or make changes to this bug.