Bug 1254435 - rename eclipse-nls-zh to eclipse-nls-zh_CN
rename eclipse-nls-zh to eclipse-nls-zh_CN
Product: Fedora
Classification: Fedora
Component: eclipse-nls (Show other bugs)
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Jens Petersen
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2015-08-18 03:11 EDT by Parag Nemade
Modified: 2016-05-17 04:06 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2016-05-17 04:06:52 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Parag Nemade 2015-08-18 03:11:25 EDT
Description of problem:
I want to request to have proper naming for zh_CN translation package. Can it be possible to rename eclipse-nls-zh to eclipse-nls-zh_CN?

I have this reasoning for this. Generally, we use locales, load locales and use translations. There is no zh locale available in 
ls /usr/share/i18n/locales/z*

only zh_* locales are there. Please consider to rename package or provide simply virtual provides.

Version-Release number of selected component (if applicable):

How reproducible:

Another reason to rename that subpackage is https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28langpacks.29

Comment 1 Sean Flanigan 2015-08-18 04:16:38 EDT
I didn't realise I was still the default assignee for eclipse-nls.

"zh" is found in /usr/share/xml/iso-codes/iso_639_3.xml as a part1_code for "zho", but I don't know if part 1 codes are acceptable according to the packaging guidelines.

I gather the package name change should help with auto-installation of Eclipse lang packs by dnf-langpacks?  

However, please note that only a few eclipse-nls packages include the country code, eg zh_TW and pt_BR, even though /usr/share/i18n/locales/ uses country codes almost exclusively.  

So by that logic we would need to rename or alias nearly all the eclipse-nls packages.  Perhaps we should.  But of course "zh" is ambiguous as to script, which isn't the case with most of the other eclipse-nls packages.

Given that eclipse-nls-zh is a repackaging of BabelLanguagePack-*-zh_*.zip (and potentially used by zh_SG users), I wonder if it might be best to keep it as the canonical name, but I do think adding a virtual provides for eclipse-nls-zh_CN (or even eclipse-nls-zh-Hans) makes sense.

However, I suppose the other way around would work too.  What do you think, Jens?
Comment 2 Parag Nemade 2016-05-17 04:06:52 EDT
Let's keep the current packaging.

Note You need to log in before you can comment on or make changes to this bug.