Bug 1254484 - Review Request: python-pluggy - The plugin manager stripped of pytest specific details
Summary: Review Request: python-pluggy - The plugin manager stripped of pytest specifi...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Haïkel Guémar
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2015-08-18 08:47 UTC by Matthias Runge
Modified: 2017-02-02 08:33 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2017-02-02 08:33:31 UTC
Type: ---
karlthered: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Matthias Runge 2015-08-18 08:47:14 UTC
Spec URL: http://www.matthias-runge.de/fedora/python-pluggy.spec
SRPM URL: http://www.matthias-runge.de/fedora/python-pluggy-0.3.0-1.fc22.src.rpm
Description: The plugin manager stripped of pytest specific details.

Fedora Account System Username: mrunge

koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10739501

Comment 1 Matthias Runge 2015-08-21 08:59:21 UTC
Adding BR to python-setuptools and define python2_sitelib

Spec URL: http://www.matthias-runge.de/fedora/python-pluggy.spec
SRPM URL: http://www.matthias-runge.de/fedora/python-pluggy-0.3.0-2.fc22.src.rpm

Comment 2 Haïkel Guémar 2015-08-21 10:33:08 UTC
Two minor issues that I trust you could easily fix before importing the package:
* typo in Source0 url, should be:
* the following directory is unowned

As soon as you fix these, it will be fully compliant with our guidelines, so I hereby
approve it into Fedora Packages Collection. Please submit a SCM request.

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 2 files have unknown license. Detailed
     output of licensecheck in /home/haikel/1254484-python-
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib/python3.4/site-
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.4/site-
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

[x]: Python eggs must not download any dependencies during the build
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

[!]: Sources can be downloaded from URI in Source: tag
     Note: Could not download Source0:
     See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Checking: python-pluggy-0.3.0-2.fc24.noarch.rpm
python-pluggy.noarch: W: spelling-error Summary(en_US) pytest -> testes
python-pluggy.noarch: W: summary-ended-with-dot C The plugin manager stripped of pytest specific details.
python-pluggy.noarch: E: no-description-tag
python-pluggy.src: W: summary-ended-with-dot C The plugin manager stripped of pytest specific details.
python-pluggy.src: E: no-description-tag
python-pluggy.src: W: invalid-url Source0: http://pypi.python.org/packages/source/t/pluggy/pluggy-0.3.0.tar.gz HTTP Error 404: Not Found
2 packages and 0 specfiles checked; 2 errors, 4 warnings.

Rpmlint (installed packages)
python-pluggy.noarch: W: summary-ended-with-dot C The plugin manager stripped of pytest specific details.
python-pluggy.noarch: E: no-description-tag
1 packages and 0 specfiles checked; 1 errors, 1 warnings.

python-pluggy (rpmlib, GLIBC filtered):


Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/usr/bin/fedora-review -b 1254484 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby

Comment 3 Matthias Runge 2015-08-21 14:24:44 UTC
Thanks for the quick review!

New Package SCM Request
Package Name: python-pluggy
Short Description: The plugin manager stripped of pytest specific details
Upstream URL: https://github.com/hpk42/pluggy
Owners: mrunge
Branches: f23, epel7

Comment 4 Gwyn Ciesla 2015-08-23 21:37:56 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2015-08-25 10:17:08 UTC
python-pluggy-0.3.0-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14210

Comment 6 Fedora Update System 2015-08-26 04:25:40 UTC
python-pluggy-0.3.0-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update python-pluggy'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14210

Comment 7 Itamar Reis Peixoto 2015-12-08 09:55:28 UTC
please submit the update to stable,it's already 4 months in updates-testing,  thank you.


Note You need to log in before you can comment on or make changes to this bug.