Created attachment 1064575 [details]
Patch to fence_virsh to treat unknown VM names as off

Description of problem:
If you have a VM running on an el5 xen host then fence_virsh does not work correctly

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Install a guest on an el5 xen system and from the guest, attempt to fence using something like `fence_virsh -l root -k /root/.ssh/id_rsa -x -o status -4 -a xenhost.company.com -n vmname -v`
2.
3.

Actual results:
[root@vmname ~]# fence_virsh -l root -k /root/.ssh/id_rsa -x -o status -4 -a xenhost.company.com -n vmname -v
Running command: /usr/bin/ssh -4  root.com -i /root/.ssh/id_rsa -p 22 -t '/bin/bash -c "PS1=\[EXPECT\]#\  /bin/bash --noprofile --norc"'
Received: [EXPECT]# 
Sent: virsh domstate vmname
Sent: 

Received: virsh domstate vmname
error: failed to get domain 'vmname'
error: Domain not found: xenUnifiedDomainLookupByName

[EXPECT]# 
Failed: You have to enter existing name/UUID of virtual machine!

Please use '-h' for usage


Expected results:
fence_virsh should return valid results

Additional info:
Xen does not return domstate info for VMs that are not currently running. Trivial fix is to return 'off' for unknown VM names as per attached patch.