Bug 1255154 - Review Request: rubygem-cabin - Experiments in structured and contextual logging
Review Request: rubygem-cabin - Experiments in structured and contextual logging
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Vít Ondruch
Fedora Extras Quality Assurance
Depends On:
Blocks: FE-DEADREVIEW 1242289
  Show dependency treegraph
Reported: 2015-08-19 15:09 EDT by Danilo Falcão
Modified: 2017-07-27 06:33 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2017-07-27 06:33:57 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Danilo Falcão 2015-08-19 15:09:06 EDT
Spec URL: https://fcon.fedorapeople.org/files/f22/rubygem-cabin.spec
SRPM URL: https://fcon.fedorapeople.org/files/f22/rubygem-cabin-0.7.1-1.fc22.src.rpm
Description: This is an experiment to try and make logging more flexible and more
Fedora Account System Username: fcon

rubygem-cabin is also a requirement for fpm, a tool that converts directories, rpms, python eggs, rubygems, and more to rpms, debs, solaris packages and more.

fpm: https://bugzilla.redhat.com/show_bug.cgi?id=1242289
Comment 1 Vít Ondruch 2015-08-20 01:24:57 EDT
Hi, I'll take this for a review and I can sponsor you as well.

From the start, please take a look at:

Comment 2 Vít Ondruch 2015-08-20 03:25:36 EDT
* Spec file differs
  - The .spec file you attached differs from the .spec file from SRPM. But they
    differs just in the initial import comment, so this is just minor nit.

* License
  - The license tag should be "ASL 2.0", according to [1].

* Test suite
  - Please execute the test suite.

* Inappropriate language in description
  - I don't think that words like "bullshit" are appropriate in package
  - I would suggest to ask upstream to change the wording.

* Exclude %{_bindir}/rubygems-cabin-test
  - I don't think this executable is useful. It seems to be just some test stuff.
  - Could you please ask upstream to remove this executable from the official
    package, i.e. drop this [2] line?

[1] https://fedoraproject.org/wiki/Licensing:Main#Software_License_List
[2] https://github.com/jordansissel/ruby-cabin/blob/master/cabin.gemspec#L18
Comment 3 Vít Ondruch 2015-10-20 07:48:44 EDT
Hi Danilo,

Any progress on this?
Comment 4 Piotr Popieluch 2015-12-21 09:27:42 EST
Is there any progress on this? Upstream version is now 0.8.0, specfile should be updated to latest upstream release.
Comment 5 Vít Ondruch 2017-07-27 06:33:57 EDT
Closing this as per policy:


Note You need to log in before you can comment on or make changes to this bug.