Red Hat Bugzilla – Bug 1255154
Review Request: rubygem-cabin - Experiments in structured and contextual logging
Last modified: 2017-07-27 06:33:57 EDT
Spec URL: https://fcon.fedorapeople.org/files/f22/rubygem-cabin.spec SRPM URL: https://fcon.fedorapeople.org/files/f22/rubygem-cabin-0.7.1-1.fc22.src.rpm Description: This is an experiment to try and make logging more flexible and more consumable. Fedora Account System Username: fcon rubygem-cabin is also a requirement for fpm, a tool that converts directories, rpms, python eggs, rubygems, and more to rpms, debs, solaris packages and more. fpm: https://bugzilla.redhat.com/show_bug.cgi?id=1242289
Hi, I'll take this for a review and I can sponsor you as well. From the start, please take a look at: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
* Spec file differs - The .spec file you attached differs from the .spec file from SRPM. But they differs just in the initial import comment, so this is just minor nit. * License - The license tag should be "ASL 2.0", according to [1]. * Test suite - Please execute the test suite. * Inappropriate language in description - I don't think that words like "bullshit" are appropriate in package description. - I would suggest to ask upstream to change the wording. * Exclude %{_bindir}/rubygems-cabin-test - I don't think this executable is useful. It seems to be just some test stuff. - Could you please ask upstream to remove this executable from the official package, i.e. drop this [2] line? [1] https://fedoraproject.org/wiki/Licensing:Main#Software_License_List [2] https://github.com/jordansissel/ruby-cabin/blob/master/cabin.gemspec#L18
Hi Danilo, Any progress on this?
Is there any progress on this? Upstream version is now 0.8.0, specfile should be updated to latest upstream release.
Closing this as per policy: https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews#Submitter_not_responding