Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1255351

Summary:	fail the fops if inode context get fails
Product:	[Community] GlusterFS	Reporter:	Raghavendra Bhat <rabhat>
Component:	bitrot	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:	bugs <bugs>
Priority:	unspecified
Version:	3.7.3	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.4	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1243391	Environment:
Last Closed:	2015-09-09 09:40:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1243391
Bug Blocks:

Description Raghavendra Bhat 2015-08-20 11:11:59 UTC

+++ This bug was initially created as a clone of Bug #1243391 +++

Description of problem:

Some fops such as readv, writev, open etc checks if the object is bad or not by getting the info from the inode context. If the inode_context_get operation fails, then bit-rot-stub still allows the fops to go through.

It should fail the fop if inode context could not be obtained.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-07-15 07:25:57 EDT ---

REVIEW: http://review.gluster.org/11449 (features/bit-rot-stub: fail the fop if inode context get fails) posted (#4) for review on master by Raghavendra Bhat (raghavendra)

--- Additional comment from Anand Avati on 2015-07-24 08:51:12 EDT ---

REVIEW: http://review.gluster.org/11449 (features/bit-rot-stub: fail the fop if inode context get fails) posted (#5) for review on master by Raghavendra Bhat (raghavendra)

--- Additional comment from Anand Avati on 2015-08-05 03:33:04 EDT ---

REVIEW: http://review.gluster.org/11449 (features/bit-rot-stub: fail the fop if inode context get fails) posted (#6) for review on master by Raghavendra Bhat (raghavendra)

--- Additional comment from Anand Avati on 2015-08-12 00:18:05 EDT ---

COMMIT: http://review.gluster.org/11449 committed in master by Venky Shankar (vshankar) 
------
commit 7b44b6c16fb538e5f15a255182de4dee781994a0
Author: Raghavendra Bhat <raghavendra>
Date:   Sat Jun 27 13:17:32 2015 +0530

    features/bit-rot-stub: fail the fop if inode context get fails
    
    In stub, for fops like readv, writev etc, if the the object is bad, then the fop
    is denied. But for checking if the object is bad inode context should be
    checked. Now, if the inode context is not there, then the fop is allowed to
    continue. This patch fixes it and the fop is unwound with an error, if the inode
    context is not found.
    
    Change-Id: I5ea4d4fc1a91387f7f9d13ca8cb43c88429f02b0
    BUG: 1243391
    Signed-off-by: Raghavendra Bhat <raghavendra>
    Reviewed-on: http://review.gluster.org/11449
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Venky Shankar <vshankar>

Comment 1 Anand Avati 2015-08-20 11:15:32 UTC

REVIEW: http://review.gluster.org/11966 (features/bit-rot-stub: fail the fop if inode context get fails) posted (#1) for review on release-3.7 by Raghavendra Bhat (raghavendra)

Comment 2 Anand Avati 2015-08-21 07:29:57 UTC

COMMIT: http://review.gluster.org/11966 committed in release-3.7 by Raghavendra Bhat (raghavendra) 
------
commit 3becc47609e04f9bfd482810ef450bd1a8703fd7
Author: Raghavendra Bhat <raghavendra>
Date:   Sat Jun 27 13:17:32 2015 +0530

    features/bit-rot-stub: fail the fop if inode context get fails
    
                           Backport of http://review.gluster.org/11449
    
    In stub, for fops like readv, writev etc, if the the object is bad, then the fop
    is denied. But for checking if the object is bad inode context should be
    checked. Now, if the inode context is not there, then the fop is allowed to
    continue. This patch fixes it and the fop is unwound with an error, if the inode
    context is not found.
    
    Change-Id: I0dcbf80889427d4c0404e00bc6c773f6fe8fc8db
    BUG: 1255351
    Signed-off-by: Raghavendra Bhat <raghavendra>
    Reviewed-on: http://review.gluster.org/11966
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kotresh HR <khiremat>

Comment 3 Kaushal 2015-09-09 09:40:09 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.4, please open a new bug report.

glusterfs-3.7.4 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12496
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user