Bug 1256328 (kf5-kholidays) - Review Request: kf5-kholidays - The KHolidays Library
Summary: Review Request: kf5-kholidays - The KHolidays Library
Keywords:
Status: CLOSED RAWHIDE
Alias: kf5-kholidays
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2015-08-24 11:25 UTC by Daniel Vrátil
Modified: 2015-11-02 01:39 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-08-31 14:31:55 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Daniel Vrátil 2015-08-24 11:25:20 UTC 
Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-kholidays.spec
SRPM URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-kholidays-15.08.0-0.1.gitfc2c49.fc22.src.rpm
Description:  The KHolidays library provides a C++ API that determines holiday and other special events for a geographical region.
Fedora Account System Username: dvratil
Comment 1 Daniel Vrátil 2015-08-24 11:26:31 UTC 
Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-kholidays.spec
SRPM URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-kholidays-15.08.0-1.fc22.src.rpm
Comment 2 Jan Grulich 2015-08-24 20:45:15 UTC 
1) Again, license should be LGPLv2+ and GPLv3+ (some files under src/parsers/plan2 are GPLv3+)

Otherwise looks good, just fix the mentioned issue during import. Approved.
Comment 3 Daniel Vrátil 2015-08-27 16:07:57 UTC 
New Package SCM Request
=======================
Package Name: kf5-kholidays
Short Description: The KHolidays library provides C++ API that determines holiday and other special events for a geographical region
Upstream URL: https://projects.kde.org/projects/kde/pim/kholidays
Owners: dvratil group::kde-sig
Branches: f21 f22 f23
InitialCC:
Comment 4 Gwyn Ciesla 2015-08-27 17:27:51 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.