Bug 1258430 - Review Request: dolphin - KDE File Manager
Summary: Review Request: dolphin - KDE File Manager
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews 1258678
TreeView+ depends on / blocked
 
Reported: 2015-08-31 11:22 UTC by Daniel Vrátil
Modified: 2016-08-14 16:25 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-09-03 00:14:12 UTC
Type: ---
Embargoed:
rdieter: fedora-review+


Attachments (Terms of Use)

Description Daniel Vrátil 2015-08-31 11:22:48 UTC
Spec URL: https://dvratil.fedorapeople.org/applications/review/dolphin.spec
SRPM URL: https://dvratil.fedorapeople.org/applications/review/dolphin-15.08.0-1.fc22.src.rpm
Description: KDE File Manager
Fedora Account System Username: dvratil

Dolphin has been split out from kde-baseapps in Applications 15.08 release, so I want to unretire the Dolphin package. The spec file has been written from scratch, because there's nothing in-common with the old one (just the name :-))

Comment 1 Christopher Meng 2015-08-31 11:34:28 UTC
%package        devel
Requires:       qt5-qtbase-devel%{?_isa}
Requires:       kf5-kio-devel%{?_isa}

%{?_isa} is needed if required package is not noarch.

Comment 2 Kevin Kofler 2015-08-31 12:10:01 UTC
Well, some code from the old KDE 3 version is probably still there somewhere. ;-) But packaging-wise, it's completely different, sure, so I'd also have rewritten the spec file from scratch.

Comment 3 Rex Dieter 2015-08-31 13:01:04 UTC
naming: ok

scriptlets: not ok
org.kde.dolphin.desktop contains:
org.kde.dolphin.desktop:MimeType=inode/directory;
1. SHOULD add mimetype scriptlet (update-desktop-database)

sources: ok
11760d094c2c3e3fff0e89b81d4db118  dolphin-15.08.0.tar.xz

builds: NOT ok, missing some buildrequires
2.  SHOULD add missing buildrequires

licensing: ok

3.  SHOULD add arch'd -devel dependencies per comment #1



APPROVED.


those items mentioned above, we can fix at our leisure prior to doing any official builds.

Comment 4 Daniel Vrátil 2015-08-31 13:10:17 UTC
Package Change Request
======================
Package Name: dolphin
New Branches: f22 f23 devel
Owners: dvratil group::kde-sig

Comment 5 Gwyn Ciesla 2015-08-31 18:01:08 UTC
Git done (by process-git-requests).

Comment 6 Rex Dieter 2015-09-01 14:04:18 UTC
I think the package still needs to be explicitly unretired, I'll look into that.

Comment 7 Rex Dieter 2015-09-01 14:06:07 UTC
https://fedoraproject.org/wiki/Package_SCM_admin_requests
says to explicitly mention that unretirement for these branches are required, so here we are.

Package Change Request
======================
Package Name: dolphin
New Branches: f22 f23 devel
Owners: dvratil group::kde-sig

Comment 8 Rex Dieter 2015-09-01 14:07:32 UTC
https://fedoraproject.org/wiki/Package_SCM_admin_requests
says to explicitly mention that unretirement for these branches are required, so here we are.

Please unretire for branches: f22 f23 devel

Comment 9 Rex Dieter 2015-09-01 14:09:34 UTC
Requested in 
https://admin.fedoraproject.org/pkgdb/package/dolphin/
too

Comment 10 Gwyn Ciesla 2015-09-01 14:28:51 UTC
Complete.


Note You need to log in before you can comment on or make changes to this bug.