Bug 1258845 - Change order of marking AFR post op
Summary: Change order of marking AFR post op
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: replicate
Version: 3.7.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ravishankar N
QA Contact:
URL:
Whiteboard:
Depends On: 1258801 1259269
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-09-01 12:01 UTC by Ravishankar N
Modified: 2015-10-14 10:38 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.7.5
Clone Of: 1258801
Environment:
Last Closed: 2015-10-14 10:30:01 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Ravishankar N 2015-09-01 12:01:41 UTC
+++ This bug was initially created as a clone of Bug #1258801 +++

Description of problem:

In AFR transaction, in the pre-op, the dirty xattr is set. In the post-op, if the transaction fails on one of the bricks, then on the healthy brick, the dirty xattr is unset and then the pending xattr (for the brick that went down) is set in that order. If the brick crashes after unsetting the dirty xattr, we have lost information about a pending heal. Hence we need to reverse the order, i.e. set pending xattr first followed by unsetting the dirty.

--- Additional comment from Anand Avati on 2015-09-01 06:36:36 EDT ---

REVIEW: http://review.gluster.org/12078 (afr: Unset dirty xattr after setting pending xattr during post-op) posted (#1) for review on master by Ravishankar N (ravishankar)

Comment 1 Anand Avati 2015-09-01 12:04:38 UTC
REVIEW: http://review.gluster.org/12079 (afr: Unset dirty xattr after setting pending xattr during post-op) posted (#1) for review on release-3.7 by Ravishankar N (ravishankar)

Comment 2 Pranith Kumar K 2015-10-14 10:30:01 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-glusterfs-3.7.5, please open a new bug report.

glusterfs-glusterfs-3.7.5 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/gluster-users/2015-October/023968.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 3 Pranith Kumar K 2015-10-14 10:38:41 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.5, please open a new bug report.

glusterfs-3.7.5 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/gluster-users/2015-October/023968.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.