1259719 – hpithres, segmentation fault in case input closed

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1259719 - hpithres, segmentation fault in case input closed

Summary: hpithres, segmentation fault in case input closed

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	openhpi
Sub Component:
Version:	7.1
Hardware:	Unspecified
OS:	Unspecified
Priority:	medium
Severity:	unspecified
Target Milestone:	rc
Target Release:	---
Assignee:	Rafael Fonseca
QA Contact:	Radka Brychtova
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:	1274397 1289025 1305230
TreeView+	depends on / blocked

Reported:	2015-09-03 12:23 UTC by Jan Ščotka
Modified:	2016-11-04 04:35 UTC (History)
CC List:	3 users (show)
Fixed In Version:	3.4.0-4
Doc Type:	No Doc Update
Doc Text:	Doc already covered by #1255041.
Clone Of:
Environment:
Last Closed:	2016-11-04 04:35:22 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2016:2357	0	normal	SHIPPED_LIVE	openhpi bug fix update	2016-11-03 13:48:56 UTC

Description Jan Ščotka 2015-09-03 12:23:25 UTC

Hi,
I've tested to use command: hpithres, and in case stdin is closed, witout quit command it causes SegFault

Version-Release number of selected component (if applicable):
hpithres - This program came with OpenHPI 3.4.0


How reproducible:
100%

Steps to Reproduce:
1.  echo "rpt" | hpithres

Actual results:
hpithres - This program came with OpenHPI 3.4.0
SAF HPI Version B.03.02

Available commands:
	exit, quit, q		- exit
	help, h			- this instruction
	rpt			- show all RPT entries
	rpt <id>		- show #id RPT entry
	rdr			- show all RDR entries
	rdr <rptid>		- show RDRs entries for #rptid
	rdr <rptid> <rdrid>	- show #rdrid RDR entry for #rptid
	sen			- show all sensors
	sen <rptid>		- show sensors for #rptid
	sen <rptid> <num>	- show #num sensor for #rptid
	mod			- modify thresholds
	undo			- delete all changes
==> rpt
  0 RPT: id =  16  ResourceId =  16  Tag = Chassis 1
  1 RPT: id =  17  ResourceId =  17  Tag = CPU 1
  2 RPT: id =  18  ResourceId =  18  Tag = DASD 1 1
  3 RPT: id =  19  ResourceId =  19  Tag = HS DASD 1 2
  4 RPT: id =  20  ResourceId =  20  Tag = Fan 1
  5 RPT: id =  21  ResourceId =  21  Tag = Chassis 3
  6 RPT: id =  22  ResourceId =  22  Tag = CPU 1
  7 RPT: id =  23  ResourceId =  23  Tag = DASD 1 1
  8 RPT: id =  24  ResourceId =  24  Tag = HS DASD 1 2
  9 RPT: id =  25  ResourceId =  25  Tag = Fan 1
 10 RPT: id =  26  ResourceId =  26  Tag = Chassis 4
 11 RPT: id =  27  ResourceId =  27  Tag = CPU 1
 12 RPT: id =  28  ResourceId =  28  Tag = DASD 1 1
 13 RPT: id =  29  ResourceId =  29  Tag = HS DASD 1 2
 14 RPT: id =  30  ResourceId =  30  Tag = Fan 1
==> Segmentation fault


Expected results:
no segfault but finish correctly

    Regards
    Honza

Comment 2 Rafael Fonseca 2015-09-03 12:53:55 UTC

Reported upstream with patch attached [1].

[1] https://sourceforge.net/p/openhpi/bugs/1899/

Comment 3 Rafael Fonseca 2015-09-04 15:41:26 UTC

Patch was accepted upstream and the fix is simple.

Comment 6 Radka Brychtova 2016-05-19 12:13:01 UTC

Old package :
openhpi-3.4.0-2.el7.x86_64

run :  echo "rpt" | hpithres 
:: [   FAIL   ] :: Test if there is no segmentation fault (Expected 0, got 139)

******************************************

New package:
 openhpi-3.4.0-3.el7.x86_64

run: echo "rpt" | hpithres 
:: [   PASS   ] :: Test if there is no segmentation fault (Expected 0, got 0)


As there is no segmentation fault in new package on all architectures => Verified

Comment 8 errata-xmlrpc 2016-11-04 04:35:22 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2357.html

Note You need to log in before you can comment on or make changes to this bug.