Bug 1260428 - [vdsm] Cannot upgrade storage pool when there was/is an unavailable domain
Summary: [vdsm] Cannot upgrade storage pool when there was/is an unavailable domain
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: General
Version: ---
Hardware: All
OS: Linux
high
high
Target Milestone: ovirt-4.0.2
: 4.18.9
Assignee: Liron Aravot
QA Contact: Kevin Alon Goldblatt
URL:
Whiteboard:
Depends On:
Blocks: 1260429
TreeView+ depends on / blocked
 
Reported: 2015-09-06 18:53 UTC by Liron Aravot
Modified: 2016-08-12 14:23 UTC (History)
27 users (show)

Fixed In Version: v4.18.7
Clone Of: 1242092
Environment:
Last Closed: 2016-08-12 14:23:30 UTC
oVirt Team: Storage
Embargoed:
ykaul: ovirt-4.0.z+
rule-engine: planning_ack+
tnisan: devel_ack+
acanan: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 45774 0 master ABANDONED sp: allow executing upgradePool even if there is a pending update 2020-10-01 10:43:38 UTC
oVirt gerrit 57188 0 master MERGED sp: allow executing upgradePool even if there is a pending update 2020-10-01 10:43:38 UTC
oVirt gerrit 59514 0 master MERGED sp: try lock when executing user initated pool upgrade 2020-10-01 10:43:37 UTC
oVirt gerrit 60519 0 ovirt-4.0 MERGED sp: allow executing upgradePool even if there is a pending update 2020-10-01 10:43:38 UTC
oVirt gerrit 60520 0 ovirt-4.0 MERGED sp: try lock when executing user initated pool upgrade 2020-10-01 10:43:37 UTC

Comment 1 Liron Aravot 2015-09-10 07:45:13 UTC 
VDSM maintainers don't want to incorporate that fix for 3.5.5 as there is a workaround, after https://bugzilla.redhat.com/show_bug.cgi?id=1260429 is solved the user can deactivate the problematic domain and then proceed with the upgrade.

postponing to 3.6
Comment 2 Allon Mureinik 2016-03-27 14:52:57 UTC 
Liron - the attached patch is abandoned. Is this something we'd EVER want to solve? The workaround seems sufficient to me - if there's really a problem accessing the domain, you can't use it, and should probably remove it from the pool.
Comment 3 Liron Aravot 2016-03-28 09:33:55 UTC 
Allon, imo it is.
When we have a problematic domain it may become available later, so we won't always want to force the user to remove it and then add it again in order to perform an upgrade - the upgrade should be allowed regardless, when the domain will become available it'll be upgraded to the needed version (as happens today).
Comment 4 Mike McCune 2016-03-28 22:54:17 UTC 
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions
Comment 5 Sandro Bonazzola 2016-05-02 10:00:55 UTC 
Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.
Comment 6 Yaniv Lavi 2016-05-23 13:16:56 UTC 
oVirt 4.0 beta has been released, moving to RC milestone.
Comment 7 Yaniv Lavi 2016-05-23 13:20:47 UTC 
oVirt 4.0 beta has been released, moving to RC milestone.
Comment 8 Allon Mureinik 2016-07-08 09:30:31 UTC 
Any news?
Comment 9 Allon Mureinik 2016-07-17 15:01:56 UTC 
Upgrade is always a hot topic. Liron - can you please supply some doctext for this BZ? Thanks!
Comment 10 Yaniv Lavi 2016-07-21 12:18:25 UTC 
Should this be ON_QA?
Comment 11 Kevin Alon Goldblatt 2016-07-25 16:25:12 UTC 
Tested with the following code:
-------------------------------------
rhevm-4.0.2-0.1.rc.el7ev.noarch
vdsm-4.18.8-1.el7ev.x86_64

Verified with the following scenario:
-------------------------------------
Steps to Reproduce:
1. Create new v3.0 DC, Cluster, Add new host
2. Add new storage domain to DC
3. Move host to maintenance
4. block connection between the host and the non master domain
5. activate the host, wait for it to become the spm
6. try to upgrade the DC -> The upgrade is successfull


Actual results:
The DC upgrade is successfull


Moving to VERIFIED!
Note You need to log in before you can comment on or make changes to this bug.