Bug 1261537 - Review Request: libs3 - C Library and Tools for Amazon S3 Access
Summary: Review Request: libs3 - C Library and Tools for Amazon S3 Access
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jon Kerr Nilsen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-09-09 15:00 UTC by Mattias Ellert
Modified: 2015-10-11 05:23 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-10-01 16:04:31 UTC
Type: ---
Embargoed:
j.k.nilsen: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Mattias Ellert 2015-09-09 15:00:23 UTC
Spec URL: http://www.grid.tsl.uu.se/review/libs3.spec
SRPM URL: http://www.grid.tsl.uu.se/review/libs3-2.0-0.1.20150902git247ba1b.fc22.src.rpm

Description:
This package includes the libs3 shared object library, needed to run
applications compiled against libs3, and additionally contains the s3
utility for accessing Amazon S3.

Fedora Account System Username: ellert

(Note to reviewer - also intended for EPEL 5, please use -DEPEL5 flag for fedora-review.)

Comment 1 Jon Kerr Nilsen 2015-09-11 07:33:21 UTC
I'll have a go at this review.

Comment 2 Jon Kerr Nilsen 2015-09-21 13:13:04 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: EPEL5: Package does run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at
     the beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: EPEL5 requires explicit %clean with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Explicit BuildRoot: tag as required by EPEL5 present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: libs3-2.0-0.1.20150902git247ba1b.fc24.x86_64.rpm
          libs3-devel-2.0-0.1.20150902git247ba1b.fc24.x86_64.rpm
          libs3-2.0-0.1.20150902git247ba1b.fc24.src.rpm
libs3.x86_64: W: no-documentation
libs3.x86_64: W: no-manual-page-for-binary s3
libs3-devel.x86_64: W: only-non-binary-in-usr-lib
libs3-devel.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 4 warnings.




Rpmlint (debuginfo)
-------------------
Checking: libs3-debuginfo-2.0-0.1.20150902git247ba1b.fc24.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
libs3-devel.x86_64: W: only-non-binary-in-usr-lib
libs3-devel.x86_64: W: no-documentation
libs3.x86_64: W: private-shared-object-provides /usr/lib64/libs3.so.2.0 libs3.so.2()(64bit)
libs3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libs3.so.2.0 /lib64/libz.so.1
libs3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libs3.so.2.0 /lib64/libm.so.6
libs3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libs3.so.2.0 /lib64/libdl.so.2
libs3.x86_64: W: no-documentation
libs3.x86_64: W: no-manual-page-for-binary s3
3 packages and 0 specfiles checked; 0 errors, 8 warnings.



Requires
--------
libs3-devel (rpmlib, GLIBC filtered):
    libs3(x86-64)
    libs3.so.2()(64bit)

libs3 (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libc.so.6()(64bit)
    libcurl.so.4()(64bit)
    libdl.so.2()(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libs3.so.2()(64bit)
    libxml2.so.2()(64bit)
    libxml2.so.2(LIBXML2_2.4.30)(64bit)
    libz.so.1()(64bit)
    rtld(GNU_HASH)



Provides
--------
libs3-devel:
    libs3-devel
    libs3-devel(x86-64)

libs3:
    libs3
    libs3(x86-64)
    libs3.so.2()(64bit)



Source checksums
----------------
https://github.com/bji/libs3/archive/247ba1bcdf133ede87366080276258b7e44cdbca/libs3-2.0-247ba1b.tar.gz :
  CHECKSUM(SHA256) this package     : 8363938782798b1e2963bf3c983899908d991d8f482a62faba1c23c80e11384a
  CHECKSUM(SHA256) upstream package : 8363938782798b1e2963bf3c983899908d991d8f482a62faba1c23c80e11384a


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -DEPEL5 -b 1261537
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, BATCH, EPEL6

Comment 3 Jon Kerr Nilsen 2015-09-21 13:13:56 UTC
No blockers.

===== APPROVED =====

Comment 4 Mattias Ellert 2015-09-21 20:56:08 UTC
Many thanks for the review.

New Package SCM Request
=======================
Package Name: libs3
Short Description: C Library and Tools for Amazon S3 Access
Owners: ellert
Branches: f21 f22 f23 el5 el6 epel7
InitialCC:

Comment 5 Gwyn Ciesla 2015-09-22 17:58:49 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2015-09-23 05:50:27 UTC
libs3-2.0-0.2.20150902git247ba1b.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16480

Comment 7 Fedora Update System 2015-09-23 05:50:32 UTC
libs3-2.0-0.2.20150902git247ba1b.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16481

Comment 8 Fedora Update System 2015-09-23 05:50:33 UTC
libs3-2.0-0.2.20150902git247ba1b.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8199

Comment 9 Fedora Update System 2015-09-23 05:50:37 UTC
libs3-2.0-0.2.20150902git247ba1b.el5 has been submitted as an update to Fedora EPEL 5. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8200

Comment 10 Fedora Update System 2015-09-23 05:50:38 UTC
libs3-2.0-0.2.20150902git247ba1b.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16482

Comment 11 Fedora Update System 2015-09-24 03:32:26 UTC
libs3-2.0-0.2.20150902git247ba1b.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update libs3'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16481

Comment 12 Fedora Update System 2015-09-24 09:53:33 UTC
libs3-2.0-0.2.20150902git247ba1b.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update libs3'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16480

Comment 13 Fedora Update System 2015-09-25 00:19:23 UTC
libs3-2.0-0.2.20150902git247ba1b.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update libs3'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8200

Comment 14 Fedora Update System 2015-09-25 00:20:01 UTC
libs3-2.0-0.2.20150902git247ba1b.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update libs3'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8198

Comment 15 Fedora Update System 2015-09-25 00:21:08 UTC
libs3-2.0-0.2.20150902git247ba1b.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update libs3'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8199

Comment 16 Fedora Update System 2015-09-25 21:21:36 UTC
libs3-2.0-0.2.20150902git247ba1b.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update libs3'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16482

Comment 17 Fedora Update System 2015-10-01 16:04:29 UTC
libs3-2.0-0.2.20150902git247ba1b.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2015-10-03 21:14:42 UTC
libs3-2.0-0.2.20150902git247ba1b.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 19 Fedora Update System 2015-10-03 21:51:14 UTC
libs3-2.0-0.2.20150902git247ba1b.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.

Comment 20 Fedora Update System 2015-10-09 14:53:02 UTC
libs3-2.0-0.2.20150902git247ba1b.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.

Comment 21 Fedora Update System 2015-10-09 22:24:56 UTC
libs3-2.0-0.2.20150902git247ba1b.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 22 Fedora Update System 2015-10-11 05:23:43 UTC
libs3-2.0-0.2.20150902git247ba1b.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.