Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1261863

Summary:	The deployment configuration validation functions should skip nodes that are in maintenance mode
Product:	Red Hat OpenStack	Reporter:	Udi Kalifon <ukalifon>
Component:	python-rdomanager-oscplugin	Assignee:	Ryan Brown <rybrown>
Status:	CLOSED ERRATA	QA Contact:	Udi Kalifon <ukalifon>
Severity:	medium	Docs Contact:
Priority:	high
Version:	7.0 (Kilo)	CC:	calfonso, dnavale, jslagle, mburns, ohochman, rhel-osp-director-maint, rybrown, sclewis
Target Milestone:	y2	Keywords:	Triaged
Target Release:	7.0 (Kilo)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-rdomanager-oscplugin-0.0.10-13.el7ost	Doc Type:	Bug Fix
Doc Text:	Previously, while checking the node configuration deployment validation checked for all Ironic nodes, including those in the maintenance mode. With this update, the nodes in maintenance mode are skipped by the validation step as they cannot be deployed.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-12-21 16:48:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Udi Kalifon 2015-09-10 10:43:38 UTC

Description of problem:
I had 2 nodes in ironic with maintenance=true. When I deployed, I got a lot of false errors and warnings on them. They should be skipped and not included in the validations.

Version-Release number of selected component (if applicable):
python-rdomanager-oscplugin-0.0.10-1.el7ost.noarch

How reproducible:
100%

Steps to Reproduce:
1. Put some nodes in maintenance. My nodes were in maintenance because I had the wrong ipmi password when I registered them.
2. Deploy

Actual results:
You get errors like this:
ERROR: rdomanager_oscplugin.v1.overcloud_deploy.DeployOvercloud Node uuid=37720334-045a-4815-8231-5bab50e88bb0 has an incorrectly configured driver_info/deploy_ramdisk. Expected "0eb164f5-dcc3-4c58-bfc4-738586051919" but got "None".
ERROR: rdomanager_oscplugin.v1.overcloud_deploy.DeployOvercloud Node uuid=37720334-045a-4815-8231-5bab50e88bb0 has an incorrectly configured driver_info/deploy_kernel. Expected "0eb164f5-dcc3-4c58-bfc4-738586051919" but got "None".
WARNING: rdomanager_oscplugin.v1.overcloud_deploy.DeployOvercloud Node uuid=37720334-045a-4815-8231-5bab50e88bb0 has an incorrectly configured properties/capabilities. Expected "boot_option:local" but got "None".
ERROR: rdomanager_oscplugin.v1.overcloud_deploy.DeployOvercloud Node uuid=cc4a7e6c-35a3-4d6f-8749-def05d4e66fa has an incorrectly configured driver_info/deploy_ramdisk. Expected "0eb164f5-dcc3-4c58-bfc4-738586051919" but got "None".
ERROR: rdomanager_oscplugin.v1.overcloud_deploy.DeployOvercloud Node uuid=cc4a7e6c-35a3-4d6f-8749-def05d4e66fa has an incorrectly configured driver_info/deploy_kernel. Expected "0eb164f5-dcc3-4c58-bfc4-738586051919" but got "None".
WARNING: rdomanager_oscplugin.v1.overcloud_deploy.DeployOvercloud Node uuid=cc4a7e6c-35a3-4d6f-8749-def05d4e66fa has an incorrectly configured properties/capabilities. Expected "boot_option:local" but got "None".

Expected results:
No false errors. These nodes should be considered as excluded (temporarily) from the setup.

Comment 4 Ryan Brown 2015-09-15 14:32:56 UTC

Upstream patch available at https://review.openstack.org/#/c/223615/

Comment 6 Mike Burns 2015-11-18 16:54:27 UTC

patch not yet in a build.

Comment 11 Udi Kalifon 2015-12-13 13:18:10 UTC

Verified in 7.2: python-rdomanager-oscplugin-0.0.10-21.el7ost.noarch

Comment 13 errata-xmlrpc 2015-12-21 16:48:57 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:2650