Spec URL: https://wfp.fedorapeople.org/perl-B-Hooks-Parser.spec SRPM URL: https://wfp.fedorapeople.org/perl-B-Hooks-Parser-0.16-1.fc22.src.rpm Description: This module provides an API for parts of the perl parser. It can be used to modify code while it's being parsed. Fedora Account System Username: wfp
Looks quite good but I still have some comments :) * Missing build time deps: - perl(DynaLoader), lib/B/Hooks/Parser.pm:7 - petr(strict), Makefile.PL:5 - perl(warnings), Makefile.PL:6 * Add a version constraint to the perl(ExtUtils::Depends) dependency. Version 0.302 is required -- Makefile.PL:11 * You may safely substitute PERL_INSTALL_ROOT with DESTDIR nowadays. * Don't explicitly (run) require perl(parent), it gets autodected. * I think you should own the %{perl_vendorarch}/auto/B and %{perl_vendorarch}/B directories.
On the directories, is it correct for me to just to add %{perl_vendorarch}/auto/B and %{perl_vendorarch}/B to the spec file? Assuming so, updated to address the comments: Spec URL: https://wfp.fedorapeople.org/perl-B-Hooks-Parser.spec SRPM URL: https://wfp.fedorapeople.org/perl-B-Hooks-Parser-0.16-2.fc22.src.rpm
Yes, this is fine. Looks good. Approving.
New Package SCM Request ======================= Package Name: perl-B-Hooks-Parser Short Description: nterface to perl's parser variables Upstream URL: http://search.cpan.org/dist/B-Hooks-Parser/ Owners: wfp Branches: f23 epel7
Please, add perl-sig as a watcher (InitialCC).
Git done (by process-git-requests).
perl-B-Hooks-Parser-0.16-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16094
perl-B-Hooks-Parser-0.16-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8122
perl-B-Hooks-Parser-0.16-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update perl-B-Hooks-Parser'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16094
perl-B-Hooks-Parser-0.16-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update perl-B-Hooks-Parser'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8122
perl-B-Hooks-Parser-0.16-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
perl-B-Hooks-Parser-0.16-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.