Bug 1263905 (ghc-old-time) - Review Request: ghc-old-time - Time library
Summary: Review Request: ghc-old-time - Time library
Keywords:
Status: CLOSED RAWHIDE
Alias: ghc-old-time
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jan Synacek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: ghc-old-locale
Blocks: ghc-8.0 ghc-7.10.3
TreeView+ depends on / blocked
 
Reported: 2015-09-17 03:31 UTC by Jens Petersen
Modified: 2016-07-13 00:57 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-07-13 00:57:46 UTC
Type: ---
Embargoed:
jsynacek: fedora-review+


Attachments (Terms of Use)

Description Jens Petersen 2015-09-17 03:31:18 UTC
Spec URL: http://petersen.fedorapeople.org//ghc-old-time.spec
SRPM URL: http://petersen.fedorapeople.org//ghc-old-time-1.1.0.3-1.fc22.src.rpm

Description:
This package provides the old time library.

For new projects, the newer <http://hackage.haskell.org/package/time time
library> is recommended.

Comment 1 Jens Petersen 2015-09-17 03:34:18 UTC
Needed for ghc-7.10 which no longer provides old-time.

Needed by about 35 Fedora packages.

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=11116547

Comment 2 Jan Synacek 2016-06-13 08:03:57 UTC
Since this is a very simply package and the spec is generated by cabal-rpm, I'm not going to post the output from fedora-review here.

All looks fine. One thing I would do, though, is change the package link in the description in the spec file to something human friendlier. It looks like it was taken straight from the markup.

Comment 3 Jens Petersen 2016-06-13 08:11:02 UTC
Thank you very for the speedy review! :-)

Good point about the url - let me fix that when importing.

Comment 4 Gwyn Ciesla 2016-06-13 13:23:43 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/ghc-old-time

Comment 5 Jens Petersen 2016-06-14 02:18:24 UTC
Built for f25-ghc:
http://koji.fedoraproject.org/koji/buildinfo?buildID=772631

Thanks again


Note You need to log in before you can comment on or make changes to this bug.