RDO tickets are now tracked in Jira https://issues.redhat.com/projects/RDO/issues/
Bug 1264072 - app-catalog-ui new package
Summary: app-catalog-ui new package
Keywords:
Status: CLOSED DUPLICATE of bug 1268372
Alias: None
Product: RDO
Classification: Community
Component: distribution
Version: trunk
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: trunk
Assignee: Alan Pevec (Fedora)
QA Contact: yeylon@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-09-17 12:45 UTC by Kevin Fox
Modified: 2016-04-18 06:54 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-10-14 18:04:24 UTC
Embargoed:


Attachments (Terms of Use)

Description Kevin Fox 2015-09-17 12:45:55 UTC
I'd like to contribute packaging for the app-catalog-ui horizon plugin to Delorean. The spec repo is located here:
https://github.com/kfox1111/app-catalog-ui

Thanks,
Kevin

Comment 1 Kevin Fox 2015-09-22 16:54:21 UTC
Ping

Comment 2 Alan Pevec (Fedora) 2015-09-25 17:37:02 UTC
I've started initial review using github comments in https://github.com/kfox1111/app-catalog-ui/commits/rpm-master

@Matthias this is Horizon UI plugin so I'd like your input, do you have any guidelines for this type of openstack packages?

Comment 3 Matthias Runge 2015-09-26 12:56:57 UTC
Unfortunately, there are no guidelines.

Python packaging guidelines apply.

How do those comments on github work? I mean, once I see something I'd change, I can not comment directly in the code.

I would fork the repo, add/change and would create a pull request.

E.g mox3 instead of mox, I would expect, we really got rid of python-lockfile. Selenium is probably not used at all, but that needs to be checked.

But in general, the spec looks quite good.

Comment 4 Kevin Fox 2015-09-28 16:51:02 UTC
yeah, I just copied an existing plugin spec and tweaked the spec. I'll remove the extra deps.

As for the procedure, I was under the impression that this would be pulled from github to somewhere else and then further review would happen there?

Thanks,
Kevin

Comment 5 Matthias Runge 2015-09-29 06:28:44 UTC
Kevin, the formal package review would be made in bugzilla. It'll follow the same process as listed here:

https://fedoraproject.org/wiki/Package_Review_Process

Comment 6 Kevin Fox 2015-10-02 16:36:54 UTC
To double check, we get a fedora package through review before a delorean package can be submitted? This is a delorean one.

Thanks,
Kevin

Comment 7 Kevin Fox 2015-10-02 21:17:29 UTC
package submitted here:
https://bugzilla.redhat.com/show_bug.cgi?id=1268372

Comment 8 Haïkel Guémar 2015-10-14 18:04:24 UTC
No reason to have two tickets, closed as duplicate.

*** This bug has been marked as a duplicate of bug 1268372 ***


Note You need to log in before you can comment on or make changes to this bug.