Bug 1264405 - Remove List<VdsNetworkInterface> nics from and pass only relevant information
Summary: Remove List<VdsNetworkInterface> nics from and pass only relevant information
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Network
Version: 3.6.0
Hardware: Unspecified
OS: Unspecified
Target Milestone: ovirt-4.0.0-beta
: ---
Assignee: Martin Mucha
QA Contact:
Depends On:
TreeView+ depends on / blocked
Reported: 2015-09-18 11:52 UTC by Martin Mucha
Modified: 2016-05-23 07:25 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2016-05-23 07:25:18 UTC
oVirt Team: Network
ylavi: ovirt-4.0.0?
rule-engine: planning_ack+
rule-engine: devel_ack+
rule-engine: testing_ack?

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
oVirt gerrit 54413 0 master MERGED core: Do not pass VdsNetworkInterface as user overrides. 2016-03-23 12:24:58 UTC
oVirt gerrit 54414 0 master MERGED core: inlined overrideNicWithUserConfiguration 2016-03-23 12:25:41 UTC
oVirt gerrit 54415 0 master MERGED core: remove duplicate method getLabelToNic 2016-03-23 12:26:11 UTC

Description Martin Mucha 2015-09-18 11:52:03 UTC
Description of problem:
it's little bit misleading, since two collections of dbNics are getting passed around, while one of which is passed only to update nics with label.

from CR: https://gerrit.ovirt.org/#/c/45298/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java

The nics in the userConfiguredData are used only to update the labels. We can pass a list of nicNameToLabel instead.

Comment 1 Yaniv Lavi 2015-10-21 09:29:45 UTC
Please explain what the impact is and how urgent it is?

Comment 2 Martin Mucha 2015-10-22 12:18:21 UTC
no impact, absolutely not urgent.

I was asked to fill a bug for it so we do not forget about it. 
It's just an design issue; to certain place is send information in overly generic datastructure; any extra stuff is simply ignored. It just make code more fragile and harder to understand.

Comment 3 Martin Mucha 2016-01-08 08:02:00 UTC
should be done after other refactorings on UI in this area are done:

Comment 4 Sandro Bonazzola 2016-05-02 10:05:57 UTC
Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.

Note You need to log in before you can comment on or make changes to this bug.