Red Hat Bugzilla – Bug 1264405
Remove List<VdsNetworkInterface> nics from and pass only relevant information
Last modified: 2016-05-23 03:25:18 EDT
Description of problem:
it's little bit misleading, since two collections of dbNics are getting passed around, while one of which is passed only to update nics with label.
from CR: https://gerrit.ovirt.org/#/c/45298/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java
The nics in the userConfiguredData are used only to update the labels. We can pass a list of nicNameToLabel instead.
Please explain what the impact is and how urgent it is?
no impact, absolutely not urgent.
I was asked to fill a bug for it so we do not forget about it.
It's just an design issue; to certain place is send information in overly generic datastructure; any extra stuff is simply ignored. It just make code more fragile and harder to understand.
should be done after other refactorings on UI in this area are done:
Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.