Bug 1264561 - Review Request: autocloud - A test framework to test Fedora cloud images
Summary: Review Request: autocloud - A test framework to test Fedora cloud images
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Praveen Kumar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-09-18 19:56 UTC by Ratnadeep Debnath
Modified: 2019-02-28 12:03 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-28 12:03:39 UTC
Type: ---
Embargoed:
kumarpraveen.nitdgp: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Ratnadeep Debnath 2015-09-18 19:56:13 UTC
Spec URL: https://rtnpro.fedorapeople.org/Packages/SPECS/autocloud.spec
SRPM URL: https://rtnpro.fedorapeople.org/Packages/SRPMS/autocloud-0.1-1.fc21.src.rpm
Description: A test framework which automatically downloads and tests Fedora cloud image builds from koji.

Fedora Account System Username: rtnpro

Comment 1 Praveen Kumar 2015-09-21 05:26:57 UTC
This is failing for build because of[0] and throw error, please include and do scratch build for rawhide and see if that build without issue.

RPM build errors:
    File must begin with "/": %{_unitdir}/autocloud.service
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
 # bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps  /builddir/build/SPECS/autocloud.spec 
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 84, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 493, in do
    raise exception.Error("Command failed. See logs for output.\n # %s" % (command,), child.returncode)
Error: Command failed. See logs for output.



https://fedoraproject.org/wiki/Packaging:Systemd#.25files_section

Comment 2 Ratnadeep Debnath 2015-09-21 20:42:44 UTC
Fixed the above errors by including systemd in BuildRequires list. Here's the updated SPEC and SRPM files:
Spec URL: https://rtnpro.fedorapeople.org/Packages/SPECS/autocloud.spec
SRPM URL: https://rtnpro.fedorapeople.org/Packages/SRPMS/autocloud-0.1-2.fc22.src.rpm

Comment 3 Praveen Kumar 2015-09-22 04:45:19 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package contains BR: python2-devel or python3-devel
- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/lib/python2.7/site-packages/autocloud
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "LGPL (v2.1 or later)", "Unknown or
     generated". 30 files have unknown license. Detailed output of
     licensecheck in /home/prkumar/fedora-
     scm/1264561-autocloud/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /etc/httpd,
     /usr/lib/systemd/system, /etc/httpd/conf.d, /usr/lib/systemd
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: autocloud-0.1-2.fc21.noarch.rpm
          autocloud-0.1-2.fc21.src.rpm
autocloud.noarch: W: spelling-error %description -l en_US koji -> Kojak
autocloud.noarch: W: no-manual-page-for-binary autocloud_job
autocloud.src: W: spelling-error %description -l en_US koji -> Kojak
2 packages and 0 specfiles checked; 0 errors, 3 warnings.




Rpmlint (installed packages)
----------------------------
autocloud.noarch: W: spelling-error %description -l en_US koji -> Kojak
autocloud.noarch: W: no-manual-page-for-binary autocloud_job
1 packages and 0 specfiles checked; 0 errors, 2 warnings.



Requires
--------
autocloud (rpmlib, GLIBC filtered):
    /bin/sh
    config(autocloud)
    fedmsg
    python(abi)
    python-flask
    python-redis
    python-retask
    python-sqlalchemy
    python-sqlalchemy-utils



Provides
--------
autocloud:
    autocloud
    config(autocloud)



Source checksums
----------------
https://github.com/kushaldas/autocloud/archive/88b1619386a843e585cd9f44bb267ed03d42ae5f.tar.gz#/autocloud-88b1619.tar.gz :
  CHECKSUM(SHA256) this package     : 36ca88f0a49a7e300cd31761760b2558326e98c8a021bc8403cfe7ff9a7ce926
  CHECKSUM(SHA256) upstream package : 36ca88f0a49a7e300cd31761760b2558326e98c8a021bc8403cfe7ff9a7ce926


Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/usr/bin/fedora-review -b 1264561
Buildroot used: fedora-21-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 4 Ratnadeep Debnath 2015-09-22 09:24:20 UTC
Fixed all the issues listed above and updated the SPEC and SRPM file at:

Spec URL: https://rtnpro.fedorapeople.org/Packages/SPECS/autocloud.spec
SRPM URL: https://rtnpro.fedorapeople.org/Packages/SRPMS/autocloud-0.1-2.fc22.src.rpm

Comment 5 Praveen Kumar 2015-09-22 09:32:35 UTC
(In reply to Ratnadeep Debnath from comment #4)
> Fixed all the issues listed above and updated the SPEC and SRPM file at:
> 
> Spec URL: https://rtnpro.fedorapeople.org/Packages/SPECS/autocloud.spec
> SRPM URL:
> https://rtnpro.fedorapeople.org/Packages/SRPMS/autocloud-0.1-2.fc22.src.rpm

Check about scm: https://fedoraproject.org/wiki/Package_SCM_admin_requests

===== Approved =====

Comment 6 Ratnadeep Debnath 2015-09-22 12:45:11 UTC
New Package SCM Request
=======================
Package Name: autocloud
Short Description: A test framework which automatically downloads and tests Fedora cloud image builds from koji.
Owners: rtnpro kushal sayanchowdhury kumarpraveen
Branches: F-23
InitialCC: rtnpro kushal sayanchowdhury kumarpraveen

Comment 7 Gwyn Ciesla 2015-09-22 19:10:54 UTC
User "sayanchowdhury" is not in the packager group

Comment 8 Ratnadeep Debnath 2015-09-23 12:14:12 UTC
=======================
Package Name: autocloud
Short Description: A test framework which automatically downloads and tests Fedora cloud image builds from koji.
Owners: rtnpro kushal kumarpraveen
Branches: F-23
InitialCC: rtnpro kushal kumarpraveen

Comment 9 Gwyn Ciesla 2015-09-23 15:38:22 UTC
User "sayanchowdhury" is not in the packager group

Comment 10 kushaldas@gmail.com 2015-09-28 14:14:52 UTC
Package Change Request
======================
Package Name: autocloud
New Branches: f22
Owners: rtnpro kushal kumarpraveen

Comment 11 Kevin Fenzi 2015-09-28 14:22:29 UTC
Git done (by process-git-requests).

Comment 12 Fedora Update System 2015-09-28 14:54:15 UTC
autocloud-0.1-5.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-591ec3c5d2

Comment 13 Fedora Update System 2015-10-02 03:48:54 UTC
autocloud-0.1-5.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update autocloud'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-591ec3c5d2

Comment 14 Upstream Release Monitoring 2015-11-13 18:37:36 UTC
csutherl's scratch build of fedora-tomcat-epel?#9661f8da0d7e82b63ef65ebe467e0eb103ae624f for el6-candidate and git://pkgs.fedoraproject.org/fedora-tomcat-epel?#9661f8da0d7e82b63ef65ebe467e0eb103ae624f failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11823023

Comment 15 Kamil Páral 2019-02-28 12:03:39 UTC
Autocloud is in Fedora, I believe this should be closed.


Note You need to log in before you can comment on or make changes to this bug.