New Package SCM Request ======================= Package Name: gl3 Short Description: gl3 Upstream URL: https://github.com/Dav1dde/gl3n Owners: bioinfornatics Branches: rawhide f23 Note: package was retired due to an old critical bug. Easy review https://admin.fedoraproject.org/pkgdb/package/gl3n/
Note: it was retired on May 11th 2015 (due to a broken dep) and thus needs a re-review.
SPEC: http://www.bioinfornatics.eu/gl3n.spec SRPMS: www.bioinfornatics.eu/gl3n-0.20150625-14.fc22.src.rpm rpmlint gl3n-0.20150625-14.fc22.src.rpm gl3n.src: I: enchant-dictionary-not-found fr gl3n.src: W: spelling-error %description -l en_US quaternions -> Quaternary gl3n.src: W: spelling-error %description -l en_US lerp -> leap, leper gl3n.src: W: spelling-error %description -l en_US slerp -> sleep, slurp gl3n.src: W: spelling-error %description -l en_US hermite -> Hermite, hermit, hermits gl3n.src: W: spelling-error %description -l en_US catmull -> cat mull, cat-mull, Catullus gl3n.src: W: spelling-error %description -l en_US rom -> ROM, Rom, tom gl3n.src: W: spelling-error %description -l en_US templated -> templates, template, template d gl3n.src: W: spelling-error %description -l fr dont -> don't gl3n.src: W: spelling-error %description -l fr ment -> meant gl3n.src: W: invalid-url Source0: gl3n-20150625git20b3487.tar.xz 1 packages and 0 specfiles checked; 0 errors, 10 warnings. waiting end of fedora-review tool
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://admin.fedoraproject.org/pkgdb/acls/name/gl3n See: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/geany, /usr/include/d, /usr/share/geany/tags [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Useful -debuginfo package or justification otherwise. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gl3n-0.20150625-14.fc22.x86_64.rpm gl3n-devel-0.20150625-14.fc22.x86_64.rpm gl3n-0.20150625-14.fc22.src.rpm gl3n.x86_64: I: enchant-dictionary-not-found fr gl3n.x86_64: W: spelling-error %description -l en_US quaternions -> Quaternary gl3n.x86_64: W: spelling-error %description -l en_US lerp -> leap, leper gl3n.x86_64: W: spelling-error %description -l en_US slerp -> sleep, slurp gl3n.x86_64: W: spelling-error %description -l en_US hermite -> Hermite, hermit, hermits gl3n.x86_64: W: spelling-error %description -l en_US catmull -> cat mull, cat-mull, Catullus gl3n.x86_64: W: spelling-error %description -l en_US rom -> ROM, Rom, tom gl3n.x86_64: W: spelling-error %description -l en_US templated -> templates, template, template d gl3n.x86_64: W: spelling-error %description -l fr dont -> don't gl3n.x86_64: W: spelling-error %description -l fr ment -> meant gl3n.x86_64: W: unstripped-binary-or-object /usr/lib64/libgl3n-ldc.so.1.0.0 gl3n.x86_64: W: no-documentation gl3n-devel.x86_64: I: enchant-dictionary-not-found fr_FR gl3n-devel.x86_64: W: only-non-binary-in-usr-lib gl3n.src: W: spelling-error %description -l en_US quaternions -> Quaternary gl3n.src: W: spelling-error %description -l en_US lerp -> leap, leper gl3n.src: W: spelling-error %description -l en_US slerp -> sleep, slurp gl3n.src: W: spelling-error %description -l en_US hermite -> Hermite, hermit, hermits gl3n.src: W: spelling-error %description -l en_US catmull -> cat mull, cat-mull, Catullus gl3n.src: W: spelling-error %description -l en_US rom -> ROM, Rom, tom gl3n.src: W: spelling-error %description -l en_US templated -> templates, template, template d gl3n.src: W: spelling-error %description -l fr dont -> don't gl3n.src: W: spelling-error %description -l fr ment -> meant gl3n.src: W: invalid-url Source0: gl3n-20150625git20b3487.tar.xz 3 packages and 0 specfiles checked; 0 errors, 22 warnings. Rpmlint (installed packages) ---------------------------- gl3n.x86_64: I: enchant-dictionary-not-found fr gl3n.x86_64: W: spelling-error %description -l en_US quaternions -> Quaternary gl3n.x86_64: W: spelling-error %description -l en_US lerp -> leap, leper gl3n.x86_64: W: spelling-error %description -l en_US slerp -> sleep, slurp gl3n.x86_64: W: spelling-error %description -l en_US hermite -> Hermite, hermit, hermits gl3n.x86_64: W: spelling-error %description -l en_US catmull -> cat mull, cat-mull, Catullus gl3n.x86_64: W: spelling-error %description -l en_US rom -> ROM, Rom, tom gl3n.x86_64: W: spelling-error %description -l en_US templated -> templates, template, template d gl3n.x86_64: W: spelling-error %description -l fr dont -> don't gl3n.x86_64: W: spelling-error %description -l fr ment -> meant gl3n.x86_64: W: unstripped-binary-or-object /usr/lib64/libgl3n-ldc.so.1.0.0 gl3n.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgl3n-ldc.so.1.0.0 /lib64/librt.so.1 gl3n.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgl3n-ldc.so.1.0.0 /lib64/libdl.so.2 gl3n.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgl3n-ldc.so.1.0.0 /lib64/libpthread.so.0 gl3n.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgl3n-ldc.so.1.0.0 /lib64/libm.so.6 gl3n.x86_64: W: no-documentation gl3n-devel.x86_64: I: enchant-dictionary-not-found fr_FR gl3n-devel.x86_64: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 0 errors, 16 warnings. Requires -------- gl3n (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libdl.so.2()(64bit) libdruntime-ldc.so.66()(64bit) libm.so.6()(64bit) libphobos2-ldc.so.66()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) rtld(GNU_HASH) gl3n-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config gl3n(x86-64) libgl3n-ldc.so.1()(64bit) Provides -------- gl3n: gl3n gl3n(x86-64) libgl3n-ldc.so.1()(64bit) gl3n-devel: gl3n-devel gl3n-devel(x86-64) pkgconfig(gl3n) Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -n gl3n Buildroot used: fedora-22-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
SPEC: http://www.bioinfornatics.eu/gl3n.spec SRPMS: http://www.bioinfornatics.eu/gl3n-0.20150625-14.fc22.src.rpm
Let me take a look at this... look for a review in a few.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= * There's a 1.2.0 release upstream, any reason not to switch to/update to that instead of using a snapshot? https://github.com/Dav1dde/gl3n/archive/v1.2.0.tar.gz I don't see any other blockers, so this package is APPROVED. Do consider updating to 1.2.0 before re-importing. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/geany, /usr/include/d, /usr/share/geany/tags [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gl3n-0.20150625-14.fc24.x86_64.rpm gl3n-devel-0.20150625-14.fc24.x86_64.rpm gl3n-0.20150625-14.fc24.src.rpm gl3n.x86_64: I: enchant-dictionary-not-found fr gl3n.x86_64: W: spelling-error %description -l en_US quaternions -> Quaternary gl3n.x86_64: W: spelling-error %description -l en_US lerp -> leap, leper gl3n.x86_64: W: spelling-error %description -l en_US slerp -> sleep, slurp gl3n.x86_64: W: spelling-error %description -l en_US hermite -> Hermite, hermit, hermits gl3n.x86_64: W: spelling-error %description -l en_US catmull -> cat mull, cat-mull, Catullus gl3n.x86_64: W: spelling-error %description -l en_US rom -> ROM, Rom, tom gl3n.x86_64: W: spelling-error %description -l en_US templated -> templates, template, template d gl3n.x86_64: W: spelling-error %description -l fr dont -> don't gl3n.x86_64: W: spelling-error %description -l fr ment -> meant gl3n.x86_64: W: unstripped-binary-or-object /usr/lib64/libgl3n-ldc.so.1.0.0 gl3n.x86_64: W: no-documentation gl3n-devel.x86_64: I: enchant-dictionary-not-found fr_FR gl3n-devel.x86_64: W: only-non-binary-in-usr-lib gl3n.src: W: spelling-error %description -l en_US quaternions -> Quaternary gl3n.src: W: spelling-error %description -l en_US lerp -> leap, leper gl3n.src: W: spelling-error %description -l en_US slerp -> sleep, slurp gl3n.src: W: spelling-error %description -l en_US hermite -> Hermite, hermit, hermits gl3n.src: W: spelling-error %description -l en_US catmull -> cat mull, cat-mull, Catullus gl3n.src: W: spelling-error %description -l en_US rom -> ROM, Rom, tom gl3n.src: W: spelling-error %description -l en_US templated -> templates, template, template d gl3n.src: W: spelling-error %description -l fr dont -> don't gl3n.src: W: spelling-error %description -l fr ment -> meant gl3n.src: W: invalid-url Source0: gl3n-20150625git20b3487.tar.xz 3 packages and 0 specfiles checked; 0 errors, 22 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory gl3n.x86_64: W: spelling-error %description -l fr dont -> don't gl3n.x86_64: W: spelling-error %description -l fr ment -> meant gl3n.x86_64: W: private-shared-object-provides /usr/lib64/libgl3n-ldc.so.1.0.0 libgl3n-ldc.so.1()(64bit) gl3n.x86_64: W: unstripped-binary-or-object /usr/lib64/libgl3n-ldc.so.1.0.0 gl3n.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgl3n-ldc.so.1.0.0 /lib64/librt.so.1 gl3n.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgl3n-ldc.so.1.0.0 /lib64/libdl.so.2 gl3n.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgl3n-ldc.so.1.0.0 /lib64/libpthread.so.0 gl3n.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgl3n-ldc.so.1.0.0 /lib64/libm.so.6 gl3n.x86_64: W: no-documentation gl3n-devel.x86_64: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 0 errors, 10 warnings. Requires -------- gl3n (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libdl.so.2()(64bit) libdruntime-ldc.so.67()(64bit) libm.so.6()(64bit) libphobos2-ldc.so.67()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) rtld(GNU_HASH) gl3n-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config gl3n(x86-64) libgl3n-ldc.so.1()(64bit) Provides -------- gl3n: gl3n gl3n(x86-64) libgl3n-ldc.so.1()(64bit) gl3n-devel: gl3n-devel gl3n-devel(x86-64) pkgconfig(gl3n) Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1264652 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Thank you Kevin SPEC: http://www.bioinfornatics.eu/gl3n.spec SRPMS: http://www.bioinfornatics.eu/gl3n-1.2.0-15.fc22.src.rpm
Looks good. thanks!
New Package SCM Request ======================= Package Name: gl3n Short Description: An OpenGL Mathematics library for D Upstream URL: https://github.com/Dav1dde/gl3n Owners: bioinfornatics Branches: rawhide f23 InitialCC: bioinfornatics
Git done (by process-git-requests). No need to request rawhide, it's automatic.