Spec URL: https://raw.githubusercontent.com/ilgrad/fedora-packages/master/rubygems/rubygem-ace-rails-ap.spec SRPM URL: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-ace-rails-ap-4.0.0-1.fc24.src.rpm Description: The Ajax.org Cloud9 Editor (Ace) for the Rails 3.1+ asset pipeline. Fedora Account System Username: ilgrad
jgrulich's scratch build of kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 for f22-candidate and git://pkgs.fedoraproject.org/kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117
(In reply to Upstream Release Monitoring from comment #1) > jgrulich's scratch build of > kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 for f22-candidate and > git://pkgs.fedoraproject.org/ > kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 completed > http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117 It is mistake?
Just a few quick points: * What about test suite? * How about bundling? This directory looks suspicious: %{gem_instdir}/vendor * You list several BuildRequires which you definitely don't need ATM, since you don't execute the test suite. * We typically try to avoid build time dependency on Bundler as much as possible. Not sure this will be the case, but its always worth asking.
Thx Vit, unfortunately the tests I have not found. I made the changes according to your notes. Spec URL: http://repo.clanwars.org/gitlab/rubygem-ace-rails-ap.spec SRPM URL: http://repo.clanwars.org/gitlab/rubygem-ace-rails-ap-4.0.0-2.fc24.src.rpm
ilgrad's scratch build of rubygem-ace-rails-ap-4.0.0-2.fc24.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11266095
(In reply to Ilya Gradina from comment #4) > unfortunately the tests I have not found. I see, no tests in upstream. Have you asked them? And even though there are no tests, it is a good habit to leave note in the .spec file. BTW how are you going address the bundling?
Hi Vit, New SPEC: https://raw.githubusercontent.com/ilgrad/fedora-packages/master/rubygems/rubygem-ace-rails-ap.spec New SRPM: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-ace-rails-ap-4.1.0-1.fc24.src.rpm the question is set: https://github.com/codykrieger/ace-rails-ap/issues/22
(In reply to Vít Ondruch from comment #6) > BTW how are you going address the bundling? You still have not addressed this concern ^^. If you are going to keep the bundled library, then you should at minimum: 1) Explain the reasons why. 2) Add the "bundled" provide. 3) Update the license, since the ACE appears to be of some BSD license. [1] https://fedoraproject.org/wiki/Bundled_Libraries#Requirement_if_you_bundle
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.