Bug 1264660 - Review Request: rubygem-mini_magick - Manipulate images
Summary: Review Request: rubygem-mini_magick - Manipulate images
Keywords:
Status: CLOSED DUPLICATE of bug 1586199
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1267323
TreeView+ depends on / blocked
 
Reported: 2015-09-19 23:18 UTC by Ilia Gradina
Modified: 2018-06-28 09:39 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-28 09:39:52 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Ilia Gradina 2015-09-19 23:18:41 UTC 
Spec URL: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-mini_magick.spec
SRPM URL: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-mini_magick-4.3.3-1.fc24.src.rpm
Description: Manipulate images with minimal use of memory via ImageMagick / GraphicsMagick
Fedora Account System Username: ilgrad
Comment 1 Vít Ondruch 2015-09-25 11:30:10 UTC 
Hi Ilya,

is the BR: rubygem(rake) required? We usually try to avoid dependency on Rake, since it tends to pull in more then necessary for build. Moreover, you don't execute any Rake command ...
Comment 2 Ilia Gradina 2015-09-29 15:15:22 UTC 
Hi Vit,

Spec URL: http://repo.clanwars.org/gitlab/rubygem-mini_magick.spec
SRPM URL: http://repo.clanwars.org/gitlab/rubygem-mini_magick-4.3.3-2.fc24.src.rpm

- remove BR: rubygem(rake) and rubygem(rspec)
- add test
Comment 3 Upstream Release Monitoring 2015-09-29 15:20:13 UTC 
ilgrad's scratch build of rubygem-mini_magick-4.3.3-2.fc24.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11266884
Comment 4 Ilia Gradina 2016-08-24 03:14:34 UTC 
New Spec: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-mini_magick.spec
New SRPM: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-mini_magick-4.5.1-1.fc24.src.rpm
Comment 5 Vít Ondruch 2016-10-05 16:12:52 UTC 
You don't specify runtime dependency on any of GraphicsMagick or ImageMagick. Shouldn't you choose one? Which is preferred? Shouldn't you use "Recommends" to make this working out of the box?
Comment 6 Pavel Valena 2018-06-28 09:39:52 UTC 

*** This bug has been marked as a duplicate of bug 1586199 ***
Note You need to log in before you can comment on or make changes to this bug.