1. IMO 3 packages needed: uchardet(bin only), libuchardet(or uchardet-libs), libuchardet-devel(or uchardet-libs-devel).

2. %doc COPYING -> %license COPYING

3. No one from upstream allows you to set version as 0.0.1, use 0.0.0 instead.

4. %description
is an encoding detector library, which takes a sequence of bytes
in an unknown character encoding without any additional information,
and attempts to determine the encoding of the text.

Sorry, I can't parse the subject.

5. No static lib please.

*** Bug 1249416 has been marked as a duplicate of this bug. ***

SPEC URL: https://github.com/ilgrad/fedora-packages/raw/master/flacon/uchardet.spec
SRPM URL: https://github.com/ilgrad/fedora-packages/raw/master/flacon/uchardet-0.0.0-2.fc24.src.rpm

1. fix number packages
2. fix license path
3. fix version
4. fix description
5. exclude static lib

Oh, but libs %description is not good, you should check and see how other $NAME-libs packages write.

Also, reason of %global debug_package %{nil} is unclear to me, or just a mistake?

This command %global debug_package %{nil} I disable debug packages, you wrote the uchardet(bin only). (or I misunderstood?)

SPEC URL: https://github.com/ilgrad/fedora-packages/raw/master/flacon/uchardet.spec
SRPM URL: https://github.com/ilgrad/fedora-packages/raw/master/flacon/uchardet-0.0.0-3.fc24.src.rpm

fix %description and Summary(libs and libs-devel).

This package has quite a few issues.

- Enable building debug packages.
i.e. remove %global debug_package %{nil}

- Making is non-verbose.
Please append V=1 to the make-call, i.e. 
make %{?_smp_mflags} V=1

- libdir is not being honored:
One way to achieve this, is this
%cmake -DCMAKE_INSTALL_LIBDIR=%{_libdir}
and to remove
mv %{buildroot}/usr/lib %{buildroot}%{_libdir}

- As you have split the package into a main package (uchardet) and a *-libs package, the main should not contain the libs (they already are in *-libs).
Please remove
%{_libdir}/lib%{name}.so.*
from the main-package's %files

- The libs are contained in *-libs. 
=> The %post/%postun scriptlets need to be added to the *-libs package and not to the main package.

Please change %post/%postun into
%post libs -p /sbin/ldconfig
%postun libs -p /sbin/ldconfig

- The package internally uses 0.0.1 as version number and not 0.0.0:
cf. CMakeLists.txt:
...
set (UCHARDET_VERSION_MAJOR 0)
set (UCHARDET_VERSION_MINOR 0)
set (UCHARDET_VERSION_REVISION 1)
...

Change your package version accordingly.

- There is a bug in upstream's PACKAGE_NAME.
cf. CMakeLists.txt:
set (PACKAGE_NAME opencc)
This likely should be "uchardet"

This doesn't seem to have an impact on the package, but please consider contacting upstream about it.

SPEC URL: https://github.com/ilgrad/fedora-packages/raw/master/flacon/uchardet.spec
SRPM URL: https://github.com/ilgrad/fedora-packages/raw/master/flacon/uchardet-0.0.1-4.git84e292d.fc24.src.rpm

- fix enable debug packages
- fix add flag verbose for make
- fix change in build
- fix remove in libs from files
- fix add change for libs in post/postun
- fix version on 0.0.1 from git
- added macros

Package opencc and uchardet are different.

Hi Ralf,

what are the next steps?

(In reply to Ilya Gradina from comment #9)
> what are the next steps?
Me to continue ;) 

Sorry, this review had dropped off my radar - I'll try to have a look into it today or tomorrow.

ok, Thx.

I am basically OK with this package, with 2 exceptions:

- %{sum}
I don't see any need for this define. IMO, all it does is to decrease readability. Please remove it.

-  %{srcname}
Simiarly to %{sum} I don't see any need for this define.

Worse, it is being used at places it doesn't make sense.

E.g. programs or libraries won't change their names just because the tarball changed its name.

Thx Ralf,

I removed extra macros.

SPEC URL: https://github.com/ilgrad/fedora-packages/raw/master/flacon/uchardet.spec
SRPM URL: https://github.com/ilgrad/fedora-packages/raw/master/flacon/uchardet-0.0.1-5.git84e292d.fc24.src.rpm

Hi Ralf,

what are the next steps?)

Hello!

I'm the new co-maintainer of uchardet. I have fixed a few things, and improved the build (with tests, and such). And in particular I have made sure that all the returned charsets are iconv-compatible (they already mostly were but 2), which is probably one of the most interesting change for using software.

The last release is version 0.0.3: https://github.com/BYVoid/uchardet/releases/tag/v0.0.3

Would it be possible to use this version for the package rather than the random git commit from your spec?
More software are using it now (mpv for instance, but also gtksourceview is going to add it as a dependency, hence gedit, etc.) and I would welcome having a stable version in the repository.
Thanks!

(In reply to Jehan from comment #15)
> Would it be possible to use this version for the package rather than the
> random git commit from your spec?

Ilya, any update?

Hi Jehan!

Thanks!)

New SPEC URL: https://github.com/ilgrad/fedora-packages/raw/master/flacon/uchardet.spec
New SRPM URL: https://github.com/ilgrad/fedora-packages/raw/master/flacon/uchardet-0.0.3-1.fc23.src.rpm

ilgrad's scratch build of uchardet-0.0.3-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11923000

New SPEC URL: https://github.com/ilgrad/fedora-packages/raw/master/flacon/uchardet.spec
New SRPM URL: https://github.com/ilgrad/fedora-packages/raw/master/flacon/uchardet-0.0.5-1.fc24.src.rpm

LGTM.

Rpmlint shows only-binary-in-usr-lib, but looks like it is a bug in rpmlint.

APPROVED.

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/uchardet

*** Bug 1305991 has been marked as a duplicate of this bug. ***

uchardet-0.0.5-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8a7ae72e2d

uchardet-0.0.5-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8a7ae72e2d

uchardet-0.0.5-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.