1264845 – [regression] Guest usb mouse/keyboard could not be used on qemu-kvm-rhev-2.3.0-24.el7.ppc64le

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1264845 - [regression] Guest usb mouse/keyboard could not be used on qemu-kvm-rhev-2.3.0-24.el7.ppc64le

Summary: [regression] Guest usb mouse/keyboard could not be used on qemu-kvm-rhev-2.3....

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	qemu-kvm-rhev
Sub Component:
Version:	7.2
Hardware:	ppc64le
OS:	Unspecified
Priority:	urgent
Severity:	urgent
Target Milestone:	rc
Target Release:	---
Assignee:	David Gibson
QA Contact:	Virtualization Bugs
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2015-09-21 11:11 UTC by Gu Nini
Modified:	2015-12-04 16:58 UTC (History)
CC List:	13 users (show)
Fixed In Version:	qemu-kvm-rhev-2.3.0-25.el7
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:	2015-12-04 16:58:37 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2015:2546	0	normal	SHIPPED_LIVE	qemu-kvm-rhev bug fix and enhancement update	2015-12-04 21:11:56 UTC

Description Gu Nini 2015-09-21 11:11:49 UTC

Description of problem:
For power pc host with qemu-kvm-rhev-2.3.0-24.el7.ppc64le, the usb mouse/keyboard could not be used in the guest

Version-Release number of selected component (if applicable):
Host kernel: 3.10.0-316.el7.ppc64le
Qemu-kvm-rhev: qemu-kvm-rhev-2.3.0-24.el7.ppc64le
SLOF: SLOF-20150313-5.gitc89b0df.el7.noarch

How reproducible:
100%

Steps to Reproduce:
1. Boot up a guest with usb mouse and keyboard:

/usr/libexec/qemu-kvm -name spaprqcow2-0921 -machine pseries,accel=kvm,usb=off -m 3072M ... -device pci-ohci,id=ohci0 -device usb-kbd,id=input0 -device usb-mouse,id=input1 -device usb-tablet,id=input2 ... -vnc 0:06 -msg timestamp=on

2. After the guest boots up, connect to the guest through vncviewer:

# vncviewer 10.16.67.19:06 --AutoSelect=0

3. Check if the mouse and keyboard could be used inside the guest

Actual results:
The mouse and keyboard could not be used inside the guest

Expected results:
The mouse and keyboard should be used inside the guest

Additional info:
1. After change the qemu version to qemu-kvm-rhev-2.3.0-23.el7.ppc64le, no the problem any more
2. The x86_64 guys with qemu version qemu-kvm-rhev-2.3.0-24.el7.x86_64 have not met the problem

Comment 1 David Gibson 2015-09-22 02:56:15 UTC

I can reproduce this.  It happens with qemu-kvm-rhev-2.3.0-24.el7.x86_64 but not with upstream qemu.

What seems to be happening is that the ohci driver in the guest isn't binding to the device, but I'm not sure why yet - there aren't any obvious error messages.

Interestingly SLOF *is* able to see and use the USB device.  But neither BE nor LE Linux guest is.

Comment 2 David Gibson 2015-09-22 06:05:30 UTC

I think I've tracked this down to the patches moving PCI device node creation to qemu.  Specifically we're missing upstream commit 4a7c347 which means the guest isn't getting the class code information it needs to match the OHCI driver to the device.

Comment 3 David Gibson 2015-09-22 06:13:32 UTC

Case for blocker status:
    * This represents a serious regression - USB interfaces (and possibly other PCI devices) won't work in Power guests any more.
    * The fix is small, low-risk and already upstream.

Karen, Miya, if you could add some ACKs to this please.

Comment 4 Xu Han 2015-09-22 10:30:39 UTC

I found PCI devices sequence has been reversed. If there are two or more virtio-blk storages, in this case, guest would assign the low address device
 with a "newer" nodename (e.g. /dev/vdb), and this behavior is different from previous.

2015-09-21 09:27:48: Populating /pci@800000020000000
2015-09-21 09:27:48:                      00 3000 (D) : 1af4 1000    virtio [ net ]
2015-09-21 09:27:48:                      00 2800 (D) : 1af4 1001    virtio [ block ]
2015-09-21 09:27:48:                      00 2000 (D) : 1af4 1001    virtio [ block ]
2015-09-21 09:27:48:                      00 1800 (D) : 106b 003f    serial bus [ usb-ohci ]
2015-09-21 09:27:48:                      00 0000 (D) : 1234 1111
2015-09-21 09:27:48: qemu vga

Is it the same cause with this issue?

Comment 5 David Gibson 2015-09-23 02:40:03 UTC

Xu Han,

Yes the change in device order probably has the same cause.  THe move to qemu DT construction is likely to have changed the order of nodes in the flattened tree, which in turn might affect guest probe order.

However, guests shouldn't generally rely on probe order (that's why mount by UUID is a good idea).  So I'm not sure it's a bug.

Comment 6 David Gibson 2015-09-23 02:48:23 UTC

Xu Han,

Yes the change in device order probably has the same cause.  THe move to qemu DT construction is likely to have changed the order of nodes in the flattened tree, which in turn might affect guest probe order.

However, guests shouldn't generally rely on probe order (that's why mount by UUID is a good idea).  So I'm not sure it's a bug.

Comment 7 Miroslav Rezanina 2015-09-23 13:27:11 UTC

Fix included in qemu-kvm-rhev-2.3.0-25.el7

Comment 8 Gu Nini 2015-09-24 03:17:50 UTC

Have updated to qemu-kvm-rhev-2.3.0-25.el7.ppc64le, for the guest new booted up, usb mouse/keyboard could be used correctly now, so the bug should be verified.

While for the PCI devices sequence reversed issue mentioned in comment 4, we should do more checks.

Comment 12 Qunfang Zhang 2015-09-25 07:25:53 UTC

The original bug has been verified pass in comment 8. And for the pci device order issue in comment 4, it still exists in the latest qemu-kvm-rhev-2.3.0-26. I created a separate bug 1266385, let's move the discussion here. 

So I will set this bug to VERIFIED first.

Comment 14 errata-xmlrpc 2015-12-04 16:58:37 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2546.html

Note You need to log in before you can comment on or make changes to this bug.