Bug 1265968 - Fedora: disk backend is not removed properly when disk frontent hotplug fails
Summary: Fedora: disk backend is not removed properly when disk frontent hotplug fails
Alias: None
Product: Fedora
Classification: Fedora
Component: libvirt
Version: 22
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Libvirt Maintainers
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2015-09-24 08:38 UTC by Allon Mureinik
Modified: 2016-01-08 03:25 UTC (History)
28 users (show)

Fixed In Version: libvirt-
Doc Type: Bug Fix
Doc Text:
Clone Of: 1262399
Last Closed: 2016-01-08 03:25:21 UTC
Type: Bug

Attachments (Terms of Use)

Comment 1 Ján Tomko 2015-09-24 11:02:06 UTC
Is there any reason to keep comment 0 on a Fedora bug private?

Comment 2 Allon Mureinik 2015-09-24 11:36:57 UTC
(In reply to Ján Tomko from comment #1)
> Is there any reason to keep comment 0 on a Fedora bug private?
The cloning brought some private links with it. 
If it's preferable, I can close this bug and open a "cleaner" bug.

Comment 3 Laine Stump 2015-10-02 17:17:15 UTC
In general, a cloned bug should always have the Comment 0 sanitized (including ), and the bug should be created as public (barring any other restrictions, such as a security issue). Sanitation should include:

 * removing the original BZ from the "Clone of" field if the original was private.
 * removing links to private mailing lists
 * sensitive data in logs
 * info about Red Hat release schedules
 * customer names/details

Any of this private information which is necessary for the new public bug (including a pointer to the original BZ, which may really be all you need) can be included in Comment 1, which can then be marked private.

The above is doubly true for Fedora and upstream bugs - although in the case of libvirt the bugs are usually worked on by someone employed by Red Hat, this is not always the case. Many people working on Fedora have no direct official association with Red Hat.

Since ovirt is a public project, if you will want to reference this BZ anywhere in ovirt release notes, mailing list, etc, you will need a public BZ. People tend to get irate when they are referred to an inaccessible page :-)

Comment 4 Fedora End Of Life 2015-11-04 10:16:50 UTC
This message is a reminder that Fedora 21 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 21. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '21'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 21 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Cole Robinson 2015-11-04 23:10:43 UTC
The patch is:

commit 4b4aade59a206b6146d90d87d591386f8fbd68d1
Author: Peter Krempa <pkrempa>
Date:   Fri Sep 11 17:34:18 2015 +0200

    qemu: hotplug: Properly clean up drive backend if frontend hotplug fails
    Commit 8125113c added code that should remove the disk backend if the
    fronted hotplug failed for any reason. The code had a bug though as it
    used the disk string for unplug rather than the backend alias. Fix the
    code by pre-creating an alias string and using it instead of the disk
    string. In cases where qemu does not support QEMU_CAPS_DEVICE, we ignore
    the unplug of the backend since we can't really create an alias in that

F21 is end of life soon, so let's just pull this in to f22+

Comment 6 Fedora Update System 2015-12-24 00:49:36 UTC
libvirt- has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-2c9678da8c

Comment 7 Fedora Update System 2015-12-30 20:56:06 UTC
libvirt- has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-2c9678da8c

Comment 8 Fedora Update System 2016-01-08 03:24:24 UTC
libvirt- has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.