Spec URL: https://melmorabity.fedorapeople.org/packages/crossguid/crossguid.spec SRPM URL: https://melmorabity.fedorapeople.org/packages/crossguid/crossguid-0-0.1.20150803git8f399e8.fc22.src.rpm Description: CrossGuid is a minimal, cross platform, C++ GUID library. It uses the best native GUID/UUID generator on the given platform and had a generic class for parsing, stringifying, and comparing IDs. Fedora Account System Username: melmorabity
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 30 files have unknown license. Detailed output of licensecheck in /home/tom/1266087-crossguid/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [!]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in crossguid-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.2.13 starting (python version = 3.4.3)... Start: init plugins INFO: selinux disabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled ccache Mock Version: 1.2.13 INFO: Mock Version: 1.2.13 Finish: chroot init INFO: installing package(s): /home/tom/1266087-crossguid/results/crossguid-0-0.1.20150803git8f399e8.fc24.x86_64.rpm /home/tom/1266087-crossguid/results/crossguid-devel-0-0.1.20150803git8f399e8.fc24.x86_64.rpm /home/tom/1266087-crossguid/results/crossguid-debuginfo-0-0.1.20150803git8f399e8.fc24.x86_64.rpm /home/tom/1266087-crossguid/results/crossguid-debuginfo-0-0.1.20150803git8f399e8.fc24.x86_64.rpm ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/compton-rawhide-x86_64/root/ --releasever 24 install /home/tom/1266087-crossguid/results/crossguid-0-0.1.20150803git8f399e8.fc24.x86_64.rpm /home/tom/1266087-crossguid/results/crossguid-devel-0-0.1.20150803git8f399e8.fc24.x86_64.rpm /home/tom/1266087-crossguid/results/crossguid-debuginfo-0-0.1.20150803git8f399e8.fc24.x86_64.rpm /home/tom/1266087-crossguid/results/crossguid-debuginfo-0-0.1.20150803git8f399e8.fc24.x86_64.rpm Rpmlint ------- Checking: crossguid-0-0.1.20150803git8f399e8.fc24.x86_64.rpm crossguid-devel-0-0.1.20150803git8f399e8.fc24.x86_64.rpm crossguid-debuginfo-0-0.1.20150803git8f399e8.fc24.x86_64.rpm crossguid-0-0.1.20150803git8f399e8.fc24.src.rpm crossguid.x86_64: W: spelling-error %description -l en_US stringifying -> stringing, stringiness, terrifying crossguid-devel.x86_64: W: only-non-binary-in-usr-lib crossguid-devel.x86_64: W: no-documentation crossguid.src: W: spelling-error %description -l en_US stringifying -> stringing, stringiness, terrifying 4 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- crossguid-debuginfo (rpmlib, GLIBC filtered): crossguid-devel (rpmlib, GLIBC filtered): crossguid(x86-64) libcrossguid.so.0()(64bit) crossguid (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) rtld(GNU_HASH) Provides -------- crossguid-debuginfo: crossguid-debuginfo crossguid-debuginfo(x86-64) crossguid-devel: crossguid-devel crossguid-devel(x86-64) crossguid: crossguid crossguid(x86-64) libcrossguid.so.0()(64bit) Source checksums ---------------- https://github.com/graeme-hill/crossguid/archive/8f399e8/crossguid-8f399e8.tar.gz : CHECKSUM(SHA256) this package : 022c9f02cc36e865cd8fd0111a597ff2bd91988deeb348dbe2aba64aed1abd99 CHECKSUM(SHA256) upstream package : 022c9f02cc36e865cd8fd0111a597ff2bd91988deeb348dbe2aba64aed1abd99 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1266087 Buildroot used: compton-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
The phrase "had a generic class" in the description should be "has a generic class" but other than that it looks fine, so package is approved. If you'd like to reciprocate then reviewing https://bugzilla.redhat.com/show_bug.cgi?id=1260375 would be a great help.
Thanks for your review :) (In reply to Tom Hughes from comment #2) > The phrase "had a generic class" in the description should be "has a generic > class" but other than that it looks fine, so package is approved. It will be fixed at package import. > If you'd like to reciprocate then reviewing > https://bugzilla.redhat.com/show_bug.cgi?id=1260375 would be a great help. Sure ;)
New Package SCM Request ======================= Package Name: crossguid Short Description: Lightweight cross platform C++ GUID/UUID library Upstream URL: https://github.com/graeme-hill/crossguid/ Owners: melmorabity Branches: f22 f23 InitialCC:
You need to file the package request in pkgdb now - see https://fedoraproject.org/wiki/PackageDB_admin_requests for details.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/crossguid
crossguid-0-0.2.20150803git8f399e8.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-bd09c2a3d2
crossguid-0-0.2.20150803git8f399e8.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update crossguid' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-b4de3e7adc
crossguid-0-0.2.20150803git8f399e8.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update crossguid' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-bd09c2a3d2
crossguid-0-0.2.20150803git8f399e8.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
crossguid-0-0.2.20150803git8f399e8.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.