based on api the user name should be provided in entity not username json field. I tried to fix VMConsoleProxyServlet: - jsonUser.put("entity", "user-id"); - jsonUser.put("username", profile.getLoginName()); + jsonUser.put("entity", profile.getLoginName()); however, I do not understand how user name is obtained from profile, it is not a field that should be there, it should be gotten from Users table '%s@%s' % (username, domain) fields. now I get 'Alon' for my 'abarlev' user. I do not know how to fix that.
(In reply to Alon Bar-Lev from comment #0) > based on api the user name should be provided in entity not username json > field. > > I tried to fix VMConsoleProxyServlet: > > - jsonUser.put("entity", "user-id"); > - jsonUser.put("username", > profile.getLoginName()); > + jsonUser.put("entity", profile.getLoginName()); > > however, I do not understand how user name is obtained from profile, it is > not a field that should be there, it should be gotten from Users table > '%s@%s' % (username, domain) fields. > > now I get 'Alon' for my 'abarlev' user. > > I do not know how to fix that. The field is not actually in the user_profiles table, we use the user_profiles_view for this purpose, which is accessed by the Get*UserProfile* SPs. Please check packaging/dbscripts/create_views.sql
ok, please extract the username and domain and construct username@profile, currently it extracts the first name or something similar.
(In reply to Alon Bar-Lev from comment #2) > ok, please extract the username and domain and construct username@profile, > currently it extracts the first name or something similar. Done, patch posted.
no impact to functionality, but it's a new feature so let's fix it as soon as practical
This is trivial fix, already reviewed. No reason to defer.
patches merged -> MODIFIED
Hi Francesco, Please provide me with the reproduction steps for this bug, so I could verify the bug.
This is a purely internal change. I'm not aware, at the moment, of any user-visible impact. The only way I can think of to verify this change is to manuyally run the ovirt-vmconsole-list.py helper and check the output. 0. make sure Engine is running, keys are registered, the flow works 1. run the tool as root, example: # /usr/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py keys 2. check the output as per description
Works for me on these components: rhevm-3.6.1.1-0.1.el6.noarch ovirt-host-deploy-java-1.4.1-1.el6ev.noarch ovirt-vmconsole-1.0.0-1.el6ev.noarch ovirt-host-deploy-1.4.1-1.el6ev.noarch ovirt-vmconsole-proxy-1.0.0-1.el6ev.noarch ovirt-engine-extension-aaa-jdbc-1.0.4-1.el6ev.noarch
According to verification status and target milestone this issue should be fixed in oVirt 3.6.1. Closing current release.