Spec URL: https://github.com/ilgrad/fedora-packages/blob/master/rubygems/rubygem-connection_pool.spec SRPM URL: https://github.com/ilgrad/fedora-packages/blob/master/rubygems/rubygem-connection_pool-2.2.0-1.fc24.src.rpm Description: Generic connection pool for Ruby. Fedora Account System Username: ilgrad
(In reply to Ilya Gradina from comment #0) > Spec URL: > https://github.com/ilgrad/fedora-packages/blob/master/rubygems/rubygem- > connection_pool.spec > SRPM URL: > https://github.com/ilgrad/fedora-packages/blob/master/rubygems/rubygem- > connection_pool-2.2.0-1.fc24.src.rpm > Description: Generic connection pool for Ruby. > Fedora Account System Username: ilgrad Spec URL: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-connection_pool.spec
Taking. I would appreciate if you would review my review request (bug 1289850). Note: It seems that you have already submitted many rubygem related package reviews which are not taken by any reviewers yet. I would suggest you offer review swaps as written on: https://fedoraproject.org/wiki/Package_Review_Process
Basically okay. Some requests and recommendations: * Unneeded document files - %{gem_instdir}/test As written on "Do not ship tests" in https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites , we request test/ directory *not* shipped in the rebuilt binary rpm. - Gemfile This is needed only for test suite and not needed on runtime. - Rakefile This is alike "Makefile" on autotools system and not needed on runtime. - %{gem_instdir}/connection_pool.gemspec This is usually needed only when creating gem itself and not needed on runtime (Note: %{gem_spec} is needed) * Other documentation recommendations * Mark %doc - Mark Changes.md as %doc * README.md - I would recommend that this file should be moved to main package because this says "README".
Hi Mamoru, thx), I fixed all yours notes: New Spec URL: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-connection_pool.spec New SRPM URL: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-connection_pool-2.2.0-2.fc23.src.rpm
Okay, now * spec file clean * source matches upstream * license ok * builds clean * installation clean * at least the following works $ ruby -e "require 'connection_pool'; puts ConnectionPool::VERSION" 2.2.0 ------------------------------------------------- This package (rubygem-connection_pool) is APPROVED by mtasaka -------------------------------------------------
ping?
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rubygem-connection-pool